From owner-freebsd-acpi@FreeBSD.ORG  Sat Jul 16 08:07:42 2011
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 870E4106564A;
	Sat, 16 Jul 2011 08:07:42 +0000 (UTC)
	(envelope-from vmagerya@gmail.com)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E1898FC18;
	Sat, 16 Jul 2011 08:07:40 +0000 (UTC)
Received: by vws18 with SMTP id 18so1839156vws.13
	for <multiple recipients>; Sat, 16 Jul 2011 01:07:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=245tk7DeLd/TAp2e1QvoDtUy2Rr964PHLbq6ml/ykBk=;
	b=wxGcJpnE+gYiw8VrPgpRzmZbhZC5tP4d1cTqhx9GHmedOmi9FcprYWuAOF1NiaPS7L
	Qq9W3jqIKWKgcS8i/kLlPx8EukWOfaBqCe7ujbUSg7ptP+Wwz3RIUhCjej0qwtUUJmyf
	0SxkKB5XC+am7fTLY0MPGhEFj6/POjhvvflv4=
MIME-Version: 1.0
Received: by 10.52.177.165 with SMTP id cr5mr990048vdc.434.1310803659737; Sat,
	16 Jul 2011 01:07:39 -0700 (PDT)
Received: by 10.52.188.193 with HTTP; Sat, 16 Jul 2011 01:07:39 -0700 (PDT)
In-Reply-To: <20110715174817.9b933756.taku@tackymt.homeip.net>
References: <BANLkTim+1UwquMJ32WP8wZBGkYxPv78MLA@mail.gmail.com>
	<20110713114521.9f684b01.taku@tackymt.homeip.net>
	<CAL409KzJwinYQU4aqqg4khL4EmwXfFfft0=S7KwzSTyxyzue6Q@mail.gmail.com>
	<201107131202.53344.jkim@FreeBSD.org>
	<20110715174817.9b933756.taku@tackymt.homeip.net>
Date: Sat, 16 Jul 2011 11:07:39 +0300
Message-ID: <CAL409Kw4wziCE6uZQUVZeAF1rEupc1Eex99+0CQ5sq9OkRpV9g@mail.gmail.com>
From: Vitaly Magerya <vmagerya@gmail.com>
To: Taku YAMAMOTO <taku@tackymt.homeip.net>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-acpi@freebsd.org, Andriy Gapon <avg@freebsd.org>
Subject: Re: (Missing) power states of an Atom N455-based netbook
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jul 2011 08:07:42 -0000

Taku YAMAMOTO <taku@tackymt.homeip.net> wrote:
> Maybe we have to tell the BIOS that we are going to utilize _CST via SMI.
> In fact, the major difference between mine and jkim's is that in mine
> I took the following snippet (which we can find in acpi_cpu_startup_cx
> function, living in sys/dev/acpica/acpi_cpu.c) out of #ifdef notyet.
>
> -#ifdef notyet
>      /* Signal platform that we can handle _CST notification. */
>      if (!cpu_cx_generic && cpu_cst_cnt != 0) {
>  	ACPI_LOCK(acpi);
>  	AcpiOsWritePort(cpu_smi_cmd, cpu_cst_cnt, 8);
>  	ACPI_UNLOCK(acpi);
>      }
> -#endif
>
> Vitaly, could you remove the above-mentioned #ifdef-#endif pair (to activate
> the code inbetween) and test jkim's patch again?

It hangs on the same spot.

>> Actually, I abandoned the patches and I am thinking about rewriting it
>> from scratch, e.g., refactoring MI/MD support code
>> (dev/acpica/acpi_cpu.c -> machine/machdep.c & acpica/acpi_machdep.c).
>> Unfortunately, I don't have much time nor hardware to test, so it
>> won't happen any time soon.  Sorry.
>>
>> If anyone wants to pick it up from here, please feel free.
>
> [...]
>
> I will happily test your new patches next time.

I'll provide any testing help needed as well.