From owner-freebsd-audit Sat Jun 2 22:51: 0 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 288E737B422; Sat, 2 Jun 2001 22:50:58 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f535onS87312; Sun, 3 Jun 2001 01:50:49 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Sun, 3 Jun 2001 01:50:46 -0400 To: Mike Heffner , Mike Barcroft From: Garance A Drosihn Subject: Re: whois(1) patch Cc: freebsd-audit@FreeBSD.ORG, phk@FreeBSD.ORG, Mike Heffner Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 6:26 PM -0400 5/31/01, Mike Heffner wrote: >On 31-May-2001 Mike Barcroft wrote: >| >| I originally made the ANSI C change to silence a warning, but is >| there any reason not to bring the code up to ANSI C spec? Is it >| likely that anyone will need to compile whois with a K&R compiler? > >It's not likely, but I'm not sure on what the consensus is on >ANSI-fication. Technically, style(9) says it shouldn't be done in >this case, but people (myself included) have been removing K&R >support in small patches like this one. I think there was also talk >of doing a full sweep to remove __P. It is not likely that there will be a specific sweep to get rid of _P() and to ansi-ify routine declarations. However, the consensus is that if you are going to be changing the declarations in some module for OTHER reasons, then you might want to ansi-ify. If you're going to ansi-ify, then you should ansi-ify the whole source file, instead of mixing styles. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message