From owner-freebsd-ports@FreeBSD.ORG Sun Apr 1 20:33:44 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CA6621065673 for ; Sun, 1 Apr 2012 20:33:44 +0000 (UTC) (envelope-from rwmaillists@googlemail.com) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by mx1.freebsd.org (Postfix) with ESMTP id 5A8978FC12 for ; Sun, 1 Apr 2012 20:33:44 +0000 (UTC) Received: by wibhj6 with SMTP id hj6so1681451wib.13 for ; Sun, 01 Apr 2012 13:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; bh=CAgePAxCUuw3BDUzUbEV19f/Ozy+f0hsCHNQouIK+tg=; b=cXOxgL7QhQ1aJ89bfRBAepBN4eOCRRezNPfmt539d2jNZ5haGIAU+l2HZd6sx7x2FL 6ufkg94npGYUO7JrUOWcShoYDt+plyezLc0fqGFio9+EtqPjaIVEbH5J9g0v8gtnyAIX Wwb7iLsxGBDtPBt6c9bEYMPoUHUOGTUL2nxxUDxZLltFxu1yR2ekUwtHFdy1obp7UrGN oG2F0oG9gDFEV5GB3V/dy9RXKk5CAz7mO26v/WIcx2kuwlBs1nDrTr7EHXla1U6s7N6P rSHD6PNBoaZNFC6lgsE4AarHKMHpncTA8IcZmam6b8CCWGAVTMIs11eQZq4j7SDIBRfa Go3A== Received: by 10.180.104.230 with SMTP id gh6mr17698563wib.22.1333312423514; Sun, 01 Apr 2012 13:33:43 -0700 (PDT) Received: from gumby.homeunix.com (87-194-105-247.bethere.co.uk. [87.194.105.247]) by mx.google.com with ESMTPS id o2sm45274174wiv.11.2012.04.01.13.33.41 (version=SSLv3 cipher=OTHER); Sun, 01 Apr 2012 13:33:42 -0700 (PDT) Date: Sun, 1 Apr 2012 21:33:40 +0100 From: RW To: ports@freebsd.org Message-ID: <20120401213340.5cea6a29@gumby.homeunix.com> In-Reply-To: <4F7827A7.3030804@yandex.ru> References: <4F7827A7.3030804@yandex.ru> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; amd64-portbld-freebsd8.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Subject: Re: Preferred way of applying OSVERSION-dependend patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2012 20:33:44 -0000 On Sun, 01 Apr 2012 14:02:15 +0400 Ruslan Mahmatkhanov wrote: > > Good day! > > What is a preferred way of doing subj? > > 1. Add an extra-patch-* to files/ subdirectory and apply it depending > of checks in Makefile (.if ${OSVERSION}). > 2. Add an patch-* to files subdirectory that applies unconditionally > and that checking for __FreeBSD_version in app code itself. > > The second one will guarantee that the patch still applies cleanly on > port versions update, It also works correctly for package files.