From owner-svn-src-all@freebsd.org Wed Feb 15 16:52:22 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 877BACE0E4C; Wed, 15 Feb 2017 16:52:22 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 548081B25; Wed, 15 Feb 2017 16:52:22 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v1FGqLSL034404; Wed, 15 Feb 2017 16:52:21 GMT (envelope-from trasz@FreeBSD.org) Received: (from trasz@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v1FGqLCk034403; Wed, 15 Feb 2017 16:52:21 GMT (envelope-from trasz@FreeBSD.org) Message-Id: <201702151652.v1FGqLCk034403@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: trasz set sender to trasz@FreeBSD.org using -f From: Edward Tomasz Napierala Date: Wed, 15 Feb 2017 16:52:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r313775 - head/sys/fs/devfs X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 16:52:22 -0000 Author: trasz Date: Wed Feb 15 16:52:21 2017 New Revision: 313775 URL: https://svnweb.freebsd.org/changeset/base/313775 Log: Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf. It's not a proper fix, but should be better than what we have now. Since it got broken some six months ago it results in an incredibly annoying and trivially reproducible panic every time eg an USB disk gets disconnected. MFC after: 2 weeks Sponsored by: DARPA, AFRL Modified: head/sys/fs/devfs/devfs_vnops.c Modified: head/sys/fs/devfs/devfs_vnops.c ============================================================================== --- head/sys/fs/devfs/devfs_vnops.c Wed Feb 15 15:32:29 2017 (r313774) +++ head/sys/fs/devfs/devfs_vnops.c Wed Feb 15 16:52:21 2017 (r313775) @@ -693,7 +693,7 @@ devfs_fsync(struct vop_fsync_args *ap) error = vop_stdfsync(ap); if (bo->bo_dirty.bv_cnt != 0 || error != 0) - panic("devfs_fsync: vop_stdfsync failed."); + printf("devfs_fsync: vop_stdfsync failed."); } return (0);