From owner-freebsd-current@FreeBSD.ORG Mon Nov 23 17:13:17 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A64E11065670; Mon, 23 Nov 2009 17:13:17 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from amailer.gwdg.de (amailer.gwdg.de [134.76.10.18]) by mx1.freebsd.org (Postfix) with ESMTP id 2A8A28FC1E; Mon, 23 Nov 2009 17:13:16 +0000 (UTC) Received: from p578b68b8.dip0.t-ipconnect.de ([87.139.104.184] helo=krabat.raven.hur) by mailer.gwdg.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1NCcTP-0001WL-PC; Mon, 23 Nov 2009 18:13:12 +0100 Message-ID: <4B0AC2A4.7020505@gwdg.de> Date: Mon, 23 Nov 2009 18:13:08 +0100 From: Rainer Hurling User-Agent: Thunderbird 2.0.0.23 (X11/20090824) MIME-Version: 1.0 To: Oliver Pinter References: <4B05C709.2090005@dougbarton.us> <20091120110123.GG2331@deviant.kiev.zoral.com.ua> <4b069fec.141bf30a.7f54.ffff8735@mx.google.com> <4B06BCC5.1000806@gwdg.de> <4B08275A.3070209@gwdg.de> <6101e8c40911211544y2347b832kda66f3217fb6aa55@mail.gmail.com> In-Reply-To: <6101e8c40911211544y2347b832kda66f3217fb6aa55@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated: Id:rhurlin X-Spam-Level: - X-Virus-Scanned: (clean) by exiscan+sophie Cc: Kostik Belousov , Aditya Sarawgi , freebsd-current@freebsd.org, delphij@freebsd.org, dougb@dougbarton.us Subject: Re: multimedia/vlc causes a panic if media files are on msdosfs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2009 17:13:17 -0000 On 22.11.2009 00:44 (UTC+1), Oliver Pinter wrote: > can you run memtest? hmmm. memtest reports no errors. And I do not think that this was a memory specific task. I observed the below described behaviour on to different machines, both running 9.0-CURRENT. And there are no panics any more after system update on november 21th. > On 11/21/09, Rainer Hurling wrote: >> On 20.11.2009 16:59 (UTC+1), Rainer Hurling wrote: >>> On 20.11.2009 20:26 (UTC+1), Aditya Sarawgi wrote: >>>> On Fri, Nov 20, 2009 at 01:01:23PM +0200, Kostik Belousov wrote: >>>>> On Thu, Nov 19, 2009 at 02:30:33PM -0800, Doug Barton wrote: >>>>>> Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=140648 for more >>>>>> information, including a trace. >>>>>> >>>>>> There is also some evidence that the same problem is triggered by >>>>>> accessing files on an NTFS partition. The VLC folks have suggested >>>>>> that the problem may be related to threading. >>>>> This is because msdosfs and ntfs are not mpsafe, and it seems that >>>>> VLC using recently added F_RDAHEAD/F_READAHEAD fcntls. >>>>> >>>>> Please try this. >>>>> >>>>> diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c >>>>> index 434f54a..676de65 100644 >>>>> --- a/sys/kern/kern_descrip.c >>>>> +++ b/sys/kern/kern_descrip.c >>>>> @@ -718,14 +718,15 @@ kern_fcntl(struct thread *td, int fd, int cmd, >>>>> intptr_t arg) >>>>> do { >>>>> new = old = fp->f_flag; >>>>> new |= FRDAHEAD; >>>>> - } while (atomic_cmpset_rel_int(&fp->f_flag, old, new) == >>>>> 0); >>>>> + } while (!atomic_cmpset_rel_int(&fp->f_flag, old, new)); >>>>> readahead_vnlock_fail: >>>>> VFS_UNLOCK_GIANT(vfslocked); >>>>> + vfslocked = 0; >>>>> } else { >>>>> do { >>>>> new = old = fp->f_flag; >>>>> new &= ~FRDAHEAD; >>>>> - } while (atomic_cmpset_rel_int(&fp->f_flag, old, new) == >>>>> 0); >>>>> + } while (!atomic_cmpset_rel_int(&fp->f_flag, old, new)); >>>>> } >>>>> fdrop(fp, td); >>>>> break; >>>> I have been getting panics with VLC on UFS filesytem too, Although the >>>> frequency of panics on a UFS filesystem is pretty low as compared to >>>> msdosfs and ntfs systems and they are very abrupt. I will try getting >>>> a trace. >>> I am observing panics also with newest vlc port on ufs2. System panics >>> whenever playing .flv files. >> With this patch even my panics went away :-) >> >> Thank you very much, >> Rainer Hurling >> >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >>