From owner-freebsd-bugs@FreeBSD.ORG  Mon Apr 25 16:10:12 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4E88106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 25 Apr 2011 16:10:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 645AB8FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 25 Apr 2011 16:10:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3PGABlb060684
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 25 Apr 2011 16:10:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3PGABQa060683;
	Mon, 25 Apr 2011 16:10:11 GMT (envelope-from gnats)
Date: Mon, 25 Apr 2011 16:10:11 GMT
Message-Id: <201104251610.p3PGABQa060683@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Robert Andersson <streambag@streambag.se>
Cc: 
Subject: Re: misc/156637: sys/types.h can't be included when _XOPEN_SOURCE
 is defined
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Robert Andersson <streambag@streambag.se>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Apr 2011 16:10:12 -0000

The following reply was made to PR misc/156637; it has been noted by GNATS.

From: Robert Andersson <streambag@streambag.se>
To: Bruce Evans <brde@optusnet.com.au>
Cc: freebsd-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org
Subject: Re: misc/156637: sys/types.h can't be included when _XOPEN_SOURCE
 is defined
Date: Mon, 25 Apr 2011 17:44:31 +0200

 On Mon, 25 Apr 2011 19:10:00 +1000 (EST)
 Bruce Evans <brde@optusnet.com.au> wrote:
 
 > 
 > I've used the following fix (the first of the above) for 10 years or
 > so (it got lost in fixes for mounds of style bugs in <sys/file.h>).
 > I didn't notice it in connection with _XOPEN_SOURCE, but by general
 > principles.
 > 
 > % Index: file.h
 > % ===================================================================
 > % RCS file: /home/ncvs/src/sys/sys/file.h,v
 > % retrieving revision 1.65
 > % diff -u -2 -r1.65 file.h
 > % --- file.h	19 Jun 2004 11:38:00 -0000	1.65
 > % +++ file.h	20 Jun 2004 02:11:04 -0000
 > % @@ -151,5 +142,5 @@
 > %  	void	*xf_data;	/* file descriptor specific
 > data */ %  	void	*xf_vnode;	/* vnode pointer */
 > % -	u_int	xf_flag;	/* flags (see fcntl.h) */
 > % +	unsigned xf_flag;	/* flags (see fcntl.h) */
 > %  };
 > %
 > 
 > Bruce
 > 
 Hi,
 
 Thanks for responding! Your patch definitely solves the problem. I
 found this when trying to port an application to FreeBSD. I guess I can
 work around the problem by patching the code using file.h
 to define __BSD_VISIBLE, but it would be great
 if this fix could be committed so that the workaround can be removed
 eventually.
 
 Cheers,
 Robert