From owner-cvs-all Thu May 17 7:30:14 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 0252037B424; Thu, 17 May 2001 07:30:06 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.3/8.11.3) with SMTP id f4HETpf18878; Thu, 17 May 2001 10:29:51 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 17 May 2001 10:29:51 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Warner Losh Cc: Matt Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_prot.c src/sys/sys ucred.h In-Reply-To: <200105170616.f4H6GcE01157@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 17 May 2001, Warner Losh wrote: > In message Robert Watson writes: > : Note that this may break binary compatibility for kernel modules that > : relied on the existing crhold() macro. As such, this probably needs a > : warning in UPDATING that modules must be recompiled, especially since this > : is in -STABLE. > > You are right, but any idea if such modules exist? Hmm. Well, credential references are manipulated by at least the NFS and SMBfs code, but I haven't really looked into much more detail. I haven't figured out the byte order issues, but it may be this has different effects on different platforms. I'd just give a general note of caution. I think having the cr_ref updating in -STABLE is great, we just need to be careful. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message