Date: Mon, 27 Sep 2010 17:54:04 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/e1000 if_em.c if_em.h if_igb.c if_igb.h if_lem.c if_lem.h src/sys/dev/ixgb if_ixgb.c if_ixgb.h src/sys/dev/ixgbe ixgbe.c ixgbe.h Message-ID: <201009271754.o8RHsM7D068480@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2010-09-27 17:54:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sys/dev/e1000 if_em.c if_em.h if_igb.c if_igb.h if_lem.c if_lem.h sys/dev/ixgb if_ixgb.c if_ixgb.h sys/dev/ixgbe ixgbe.c ixgbe.h Log: SVN rev 213218 on 2010-09-27 17:54:04Z by yongari MFC r211913: Do not allocate multicast array memory in multicast filter configuration function. For failed memory allocations, em(4)/lem(4) called panic(9) which is not acceptable on production box. igb(4)/ixgb(4)/ix(4) allocated the required memory in stack which consumed 768 bytes of stack memory which looks too big. To address these issues, allocate multicast array memory in device attach time and make multicast configuration success under any conditions. This change also removes the excessive use of memory in stack. Reviewed by: jfv Revision Changes Path 1.21.2.16 +14 -8 src/sys/dev/e1000/if_em.c 1.5.2.4 +2 -0 src/sys/dev/e1000/if_em.h 1.21.2.16 +16 -1 src/sys/dev/e1000/if_igb.c 1.4.2.5 +2 -0 src/sys/dev/e1000/if_igb.h 1.3.2.9 +14 -8 src/sys/dev/e1000/if_lem.c 1.2.2.4 +2 -0 src/sys/dev/e1000/if_lem.h 1.25.2.3 +16 -1 src/sys/dev/ixgb/if_ixgb.c 1.9.10.2 +2 -0 src/sys/dev/ixgb/if_ixgb.h 1.17.2.9 +16 -1 src/sys/dev/ixgbe/ixgbe.c 1.9.2.5 +2 -0 src/sys/dev/ixgbe/ixgbe.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009271754.o8RHsM7D068480>