From owner-svn-src-head@freebsd.org Sun Jun 19 08:08:10 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6F0BA7ACEF; Sun, 19 Jun 2016 08:08:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78913205F; Sun, 19 Jun 2016 08:08:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x232.google.com with SMTP id 187so1314544wmz.1; Sun, 19 Jun 2016 01:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=eV8cLX63cu50liV5LaGw+PfR1n8tUcPnjb5lEZkY4L8=; b=a8nqQUG8iMEhY7dFF7QURmqEQAMi4gKXaUCSiz6l2IBcWvXlr48QieSeuusStwHlAx tqNI7uJ1y6fXjawSVHRMBY86lB6xjF4UoXhRrqAAQSbSFFF12UxIDkaXOMwttYwi+8yB EVQwnhgOSzbnwzhh/pGPH+bGIQ9RCyA7Te0P2dBtLukcLOXv8BFrDb2sf2JuNUKgTdn6 qjv++2fLZQxLmggnkqqbaFdwyjxzyYYzBzAkhR8/fG+V3RZyor6EU8djY4EvrptCLOLo oLC6Z3IDAh52hhKqPOv3hppZFh39CLAtfEuw0/5MBWmShZ7NOCSdBwTsYjmPLPOuYCvN rCWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=eV8cLX63cu50liV5LaGw+PfR1n8tUcPnjb5lEZkY4L8=; b=CWMhMeR38zl6IMfPUKq31SAceq61lS8gWmmnd5CTH47eocMiph0MDkoDdXFG1+2r+J wQ1dZ8WSb5etEcBxal1HYsjebYrBK1qrSW7u38zzVANssaww1mZPm6qbaa8BUu8+dIOr vjdCxZG4XsWAD5KkqVmR54DNHIQxXdM2EzqPXMIdoTKvoSvJaIIg/X3tN/BRZKOwp2ij KeMOdapVnlr99EnIUSoOkhV9UIJamalM4tRHeWl6T0/Gj5pqUjgBibcWxgaH22JFVEg9 LplSWXKYENfBjEF6s79VYSddCTnN7q+/WIBnHHW1xtJIYTcKH9H9sDjw8RFf8w4AmjRM Jxkg== X-Gm-Message-State: ALyK8tLc+z3Pttes87+ngFsS+7J9ALZQaAYellSdlFlSerDDGxxW4CRroGhLD6sTVBLT8A== X-Received: by 10.194.81.72 with SMTP id y8mr9997771wjx.83.1466323688074; Sun, 19 Jun 2016 01:08:08 -0700 (PDT) Received: from brick (abpy178.neoplus.adsl.tpnet.pl. [83.8.66.178]) by smtp.gmail.com with ESMTPSA id e5sm57365008wjj.10.2016.06.19.01.08.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 01:08:07 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 19 Jun 2016 10:08:03 +0200 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Jan Beich Cc: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299448 - in head/sys/cddl/contrib/opensolaris: common/acl uts/common/fs/zfs uts/common/sys Message-ID: <20160619080803.GA1638@brick> Mail-Followup-To: Jan Beich , Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201605111343.u4BDhKhp076695@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 08:08:11 -0000 On 0614T0232, Jan Beich wrote: > Alexander Motin writes: > > > Author: mav > > Date: Wed May 11 13:43:20 2016 > > New Revision: 299448 > > URL: https://svnweb.freebsd.org/changeset/base/299448 > > > > Log: > > MFV r299442: 6762 POSIX write should imply DELETE_CHILD on directories - and > > some additional considerations > > > > Reviewed by: Gordon Ross > > Reviewed by: Yuri Pankov > > Author: Kevin Crowe > > > > openzfs/openzfs@d316fffc9c361532a482208561bbb614dac7f916 > > This commit confuses acl_is_trivial_np(3). Notice '+' in ls(1) and 'D' > in getfacl(1) outputs. It's not just that. Those changes: 1. Confuse acl_is_trivial_np(3), as you say. It's hard to fix in libc, because they make trivial ACLs different for files and directories, and acl_is_trivial_np(3) has no way of telling which is which. 2. They make delete deny permission take precedence over the containing directory write allow permission, which is rather different from what people expect in unix systems, and is against the NFSv4 specification, even though it might be a better fit for Windows. 3. They make umask apply to inherit_only permissions, and 4. I don't fully understand this one yet, but from the ACL regression test suite (which lives in tests/sys/acl/, and I'd appreciate people actually ran this before committing ACL-related changes) it looks like it makes umask not apply to the stuff it should. The #1 could be fixed by making ZFS not setting delete_child on write, basically reverting to the previous behaviour in that aspect. As for the others... I'm not saying each one of those is wrong, but they certainly warrant further discussion, especially #2 and #4. Basically, what I'm trying to say is that we should consider backing this out for 11.0-RELEASE, reverting to the previous semantics, verified by passing the regression tests.