Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 09 Mar 2010 18:25:14 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        obrien@FreeBSD.org
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "M. Warner Losh" <imp@bsdimp.com>
Subject:   Re: svn commit: r204824 - head/sys/conf
Message-ID:  <4B97030A.1040704@FreeBSD.org>
In-Reply-To: <20100310015551.GA12405@dragon.NUXI.org>
References:  <201003071008.o27A80wC014578@svn.freebsd.org> <20100307.143619.510313205755027975.imp@bsdimp.com> <20100308010125.GA6387@dragon.NUXI.org> <4B945CAC.9020706@FreeBSD.org> <20100310015551.GA12405@dragon.NUXI.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 03/09/10 17:55, David O'Brien wrote:
> On Sun, Mar 07, 2010 at 06:10:52PM -0800, Doug Barton wrote:
>> On 03/07/10 17:01, David O'Brien wrote:
>>> +*/sys/*|*/compile/*)
>>
>> Please revert your previous change, and feel free to add this one instead.
>>
>> I'm a little aggravated because this question of "what if the directory
>> isn't named */sys/*?" was already addressed when I made the change, and
>> the general agreement was that !sys was an edge case that wasn't worth
>> worrying about.
> 
> I probably would have if I had been able to update my main system to a
> kernel newer than Nov 9th.  Every time I've tried HEAD is toxic[*].
> Tried again this morning - "no route to 127.0.0.1".

I'm not sure what the connection is there. But FWIW Qing posted the fix
for that: http://people.freebsd.org/~qingli/route.h.diff. Not sure why
he hasn't committed it yet. The fix works for me.

>> I'm even more aggravated that your change doesn't work for the common case.
> 
> Sorry, I build all my kernels the traditional way.  I was agrivated that
> your change didn't work with the kernel build method with 15 years
> history...

The "traditional" way hasn't been the recommended method of kernel
building for years now.

In any case, at least one user has complained on the list that not
having the svn revision in uname has caused them an actual problem, so I
backed out your change today. If you'd like to submit a patch for review
(-current or -hackers are good choices) that ADDS support for
*/compile/* I have no objection, and as long as it doesn't cause any
problems for people whose sources are in */sys/* I think that'd be
great, and will do whatever I can to help.


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B97030A.1040704>