From owner-freebsd-current@FreeBSD.ORG Fri Oct 25 01:50:11 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1ABC1C79 for ; Fri, 25 Oct 2013 01:50:11 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm28.bullet.mail.bf1.yahoo.com (nm28.bullet.mail.bf1.yahoo.com [98.139.212.187]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BD2B12F41 for ; Fri, 25 Oct 2013 01:50:10 +0000 (UTC) Received: from [66.196.81.170] by nm28.bullet.mail.bf1.yahoo.com with NNFMP; 25 Oct 2013 01:50:04 -0000 Received: from [98.139.213.13] by tm16.bullet.mail.bf1.yahoo.com with NNFMP; 25 Oct 2013 01:50:04 -0000 Received: from [127.0.0.1] by smtp113.mail.bf1.yahoo.com with NNFMP; 25 Oct 2013 01:50:04 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1382665804; bh=bT9IHA/Ta5Gwejhodgp4YpfX0L0isyy5BkEhoQYFqGI=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=gibCq7hjATtImnUj8iuCg+oVEXBYrIqUnuuHM4zw/pz+iis7D4/xPIuAUGK2976nrT6UptxWY1fgvy/NFh2EYQzd3dHzEzsKB7BjHm++N1/61AgSJggCqAYp6pW4qpa65KOqkhVOB4cQmpfutso0yFrW+PmQHjx+5FI46y0hCvk= X-Yahoo-Newman-Id: 735772.96811.bm@smtp113.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: y2kv0skVM1mwntMEXQboFmQ4_azcNV07P.OUWBFhJr0KBJj lVMEAFEW.q26R9mmxyeUF5BdTjfeQNw2gmOCtnWEY1PMZbatTGnZTb0VSeox Mh7FAs1cU8O9A6ssUKST.XqUOJUvEiclhcdLRLD8T0MKzlNTcGcRHCp0m37Y hsJan8Yl7im9vUyP7OQiVFKXlnaqyYq_HLHnoqazW3uG._J6hnqiNnHz43Nh tE01WWLiidFX8scGCCGxhDUCtBndu3sce2B3pBfYu38Do67QzxStLBb5O8cO epyQFUPgLOSlvswz3qU.FFOEOz6jbp299Y77N04RcwCwfaSGbf9QHFm7VoDq wN3Gskk4tGxOW2zjZx2IbZ8cGAhIRoWwAbfOACZTXL7pn5SzQVPrJmuWksps qG1maotJ5PAeffzzK2.OzltbxPdY6jvMHODxL7euHpFUwjnHd..wGKTvCip. .c14C.cYFyuD13xNUsv2kue6MxFv9DFyi5X6ysKWa46qCf4Tklomy_jtprLC sanH91v9XBAFeLkXoPcq1S5ftf.CIYJWZMVM9fyOZ3dzJcFapftL4nebx0ix CAao4lRVAVbQRc2B8mqAnPqunV7nD4vBlkivD.I4ZxAeUISg- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.100.5] (sean_bruno@63.138.121.126 with ) by smtp113.mail.bf1.yahoo.com with SMTP; 24 Oct 2013 18:50:04 -0700 PDT Subject: Re: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses From: Sean Bruno To: David Chisnall In-Reply-To: <3656E3A3-F76E-42F4-BCFC-8B0F49FF5DA9@FreeBSD.org> References: <1382327452.2610.5.camel@localhost> <1382399026.7749.3.camel@localhost> <0744E30D-89EF-4340-A7DC-968AC27F302B@FreeBSD.org> <1382663626.2498.4.camel@localhost> <3656E3A3-F76E-42F4-BCFC-8B0F49FF5DA9@FreeBSD.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-TNhDroFGnTjCoIc8Tmhh" Date: Thu, 24 Oct 2013 21:50:03 -0400 Message-ID: <1382665803.2498.13.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: Matthew Fleming , "freebsd-current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 01:50:11 -0000 --=-TNhDroFGnTjCoIc8Tmhh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Thu, 2013-10-24 at 21:24 -0400, David Chisnall wrote: >=20 > Don't forget the freelocale() at the end. >=20 ah, ok. I wish that there was some kind of example that I could go off of in the man page. I'm sort of trundling my way through various bits of the system to find the obvious example of how to do this correctly. > This seems like a very slow way of doing what was very fast in the > original code though. I'm not entirely sure what you're aiming to > gain in this refactoring. >=20 > David >=20 >=20 I'm simply trying to address the warnings that appear due to clang. I find the builds very noisy and if there's a better way to address this issue, I'm totally open to suggestions. sean --=-TNhDroFGnTjCoIc8Tmhh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSac5LAAoJEBkJRdwI6BaHSFEH/0ZrMnxS14XinHEsu+gBcty1 Czxr2pd9xLwudM3CRkS5qton30KCzneSH33AzS9q6osHKwQaoijcbdYTsMNo2e7k EWQ/68hxSnadJmRWQ2hp7iByXF6oPYxvS6tIi07RZbLZxe9NJOQbcqvWpEK/Lgn+ JpVkNSELrKg7NP0BnWZLNhpwDYhh18u1NTdwQCskvs2K+RALVVkNLwA0M8hzDUQ7 2IsVHCWToRkURl6kMGrpAFTNe/CXbvwBl0th6q7rg6G4tStBXUSyUCiAkze90liu 8ADzEMLDKTOnZEU9X6MsrWAv0q9q+tasuCbKUlEkBDocc9FNp5m3TvDglAOb6U0= =/QmL -----END PGP SIGNATURE----- --=-TNhDroFGnTjCoIc8Tmhh--