From owner-freebsd-ports@FreeBSD.ORG Mon Sep 17 16:43:28 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AFAA31065672; Mon, 17 Sep 2012 16:43:28 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 044488FC1C; Mon, 17 Sep 2012 16:43:27 +0000 (UTC) Received: by lbbgg13 with SMTP id gg13so5355046lbb.13 for ; Mon, 17 Sep 2012 09:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ljHH8KO3eJB5c7LGcCcM2IRV59WBZ1PoVYw45hRWLCI=; b=ZNBBQ9hEVfXdy7HCeAfHDq04yfr0S9ODpGO2XLeUqno/o0919j4gacX1IMtiTs4/H/ UqIEa97PzwKH23KAo+Mj5tmMEWmV6NGCLwCIsRYW+eDfajbAj/yQbkG19g65UW56htkL tcn17YGv1lFXh4TtvawimrXyIraD6Uf1mgGOaoxueBo7TPYF56Y3HUK7he2zaWlAf4Jy OhiFrWnbv5vLO0549Y0K3G4GBaQHHrzfArLvRy9xzS9eoXqGft9FoHX5qj0wl0v/M4v/ eO6NMOvLDMa+JLA/G3yTun1ucIEI+28IgZ49cieiYvvkoxJB9VslReoxNbOLbiTMYj3W iGpw== MIME-Version: 1.0 Received: by 10.112.37.8 with SMTP id u8mr4139932lbj.30.1347900206930; Mon, 17 Sep 2012 09:43:26 -0700 (PDT) Received: by 10.114.23.230 with HTTP; Mon, 17 Sep 2012 09:43:26 -0700 (PDT) In-Reply-To: <20120917163310.GA57928@freefall.freebsd.org> References: <20120917163310.GA57928@freefall.freebsd.org> Date: Mon, 17 Sep 2012 09:43:26 -0700 Message-ID: From: Freddie Cash To: Thomas Abthorpe Content-Type: text/plain; charset=UTF-8 Cc: ports@freebsd.org Subject: Re: [CORRECTION] Change to the header in ports Makefiles, take two X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2012 16:43:28 -0000 On Mon, Sep 17, 2012 at 9:33 AM, Thomas Abthorpe wrote: > It was recently posted on, > http://blogs.freebsdish.org/portmgr/2012/09/01/change-to-the-header-in-ports-makefiles/ > that we would adopt a new header for the ports Makefiles. The initial > discussion seemed to show enough support for the idea of completely > stripping the header, leaving only the $FreeBSD$ tag. After the > announcement was made, more people stated strong feelings that when and > where possible attribution be maintained in the header. > > A private discussion was held among ports committers, and while opinions > were as varied as the individuals who shared them, it was decided to unify > on a two line header. > > # Created by: J.Q. Public > # $FreeBSD$ > > The Whom line from the classic six line header becomes Created By. > > Sometimes, as a result of a repocopy, or changed maintainership, the > Created By and MAINTAINER is no longer in synchronisation. To avoid > confusion, the first line can be removed, optionally leaving us with a one > line header. > > # $FreeBSD$ Wouldn't it make sense to have the "# $FreeBSD$" line be the first line of the file, so that it never changes? Having some files where the FreeBSD tag is first, and other files where it's second seems arbitrarily inconsistent. Lines that don't change should come first, so that things are always the same. IMHO, of course. :) -- Freddie Cash fjwcash@gmail.com