From owner-svn-src-all@freebsd.org Wed May 30 10:39:45 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 089F4F7F30D; Wed, 30 May 2018 10:39:45 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8FFC67B4D2; Wed, 30 May 2018 10:39:44 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 18A793A413; Wed, 30 May 2018 12:39:36 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_AFAF1CA4-C769-4151-A883-B4A1386A67C8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: svn commit: r334361 - head/usr.sbin/pmc Date: Wed, 30 May 2018 12:39:32 +0200 In-Reply-To: <20180530092459.GP3789@kib.kiev.ua> Cc: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Konstantin Belousov References: <201805300006.w4U06HK3055256@repo.freebsd.org> <20180530092459.GP3789@kib.kiev.ua> X-Mailer: Apple Mail (2.3445.6.18) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 10:39:45 -0000 --Apple-Mail=_AFAF1CA4-C769-4151-A883-B4A1386A67C8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 30 May 2018, at 11:24, Konstantin Belousov = wrote: >=20 > On Wed, May 30, 2018 at 12:06:17AM +0000, Matt Macy wrote: >> Author: mmacy >> Date: Wed May 30 00:06:17 2018 >> New Revision: 334361 >> URL: https://svnweb.freebsd.org/changeset/base/334361 >>=20 >> Log: >> pmc: don't break build with format issues >>=20 >> Modified: >> head/usr.sbin/pmc/Makefile >>=20 >> Modified: head/usr.sbin/pmc/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/usr.sbin/pmc/Makefile Tue May 29 23:08:33 2018 = (r334360) >> +++ head/usr.sbin/pmc/Makefile Wed May 30 00:06:17 2018 = (r334361) >> @@ -9,4 +9,5 @@ LIBADD=3D kvm pmc m ncursesw pmcstat elf >>=20 >> SRCS=3D pmc.c pmc_util.c cmd_pmc_stat.c >>=20 >> +CWARNFLAGS.cmd_pmc_stat.c=3D -Wno-format >> .include > So this builds knownly broken binary instead of stopping. >=20 > If I understand your troubles right, the usual solution for them is > printf("%jx", (uintmax_t)trouble); > used in many places around the kernel, less so in userspace. Yes, or include and use the PRIu64 macro, even though Bruce hates it. :) -Dimitry --Apple-Mail=_AFAF1CA4-C769-4151-A883-B4A1386A67C8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWw5/ZAAKCRCwXqMKLiCW o64dAJ9GAEJ/8CtJOtWAZ6g/961XkkbscwCg/ZT6CN4vKovKqV+cOTL3/D69sRg= =dngA -----END PGP SIGNATURE----- --Apple-Mail=_AFAF1CA4-C769-4151-A883-B4A1386A67C8--