From owner-svn-src-all@FreeBSD.ORG Mon Mar 2 14:49:03 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 21E4E144 for ; Mon, 2 Mar 2015 14:49:03 +0000 (UTC) Received: from vfemail.net (nine.vfemail.net [108.76.175.9]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7BB39D2 for ; Mon, 2 Mar 2015 14:48:57 +0000 (UTC) Received: (qmail 83189 invoked by uid 89); 2 Mar 2015 14:48:05 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 2 Mar 2015 14:48:05 -0000 Received: (qmail 69724 invoked by uid 89); 1 Mar 2015 19:39:22 -0000 Received: by simscan 1.3.1 ppid: 69716, pid: 69720, t: 0.0037s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 1 Mar 2015 19:39:22 -0000 Received: (qmail 11148 invoked by uid 89); 1 Mar 2015 19:39:44 -0000 Received: by simscan 1.4.0 ppid: 11094, pid: 11138, t: 1.7131s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 1 Mar 2015 19:39:42 -0000 From: Jan Beich To: Jean-Sebastien Pedron Subject: Re: svn commit: r279487 - head/sys/dev/pci References: <201503011247.t21Clb2p035966@svn.freebsd.org> Date: Sun, 01 Mar 2015 20:39:30 +0100 In-Reply-To: <201503011247.t21Clb2p035966@svn.freebsd.org> (Jean-Sebastien Pedron's message of "Sun, 1 Mar 2015 12:47:37 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2015 14:49:03 -0000 --=-=-= Content-Type: text/plain Jean-Sebastien Pedron writes: > Modified: head/sys/dev/pci/vga_pci.c [...] > +int > +vga_pci_repost(device_t dev) > +{ > +#if defined(__amd64__) || defined(__i386__) > + x86regs_t regs; > + > + if (!vga_pci_is_boot_display(dev)) > + return (EINVAL); > + > + if (x86bios_get_orm(VGA_PCI_BIOS_SHADOW_ADDR) == NULL) > + return (ENOTSUP); > + > + x86bios_init_regs(®s); [...] This breaks build for a kernel without VESA or X86BIOS. Also, x86bios maybe loaded later as a module. $ make buildkernel --- kernel.debug --- linking kernel.debug vga_pci.o: In function `vga_pci_repost': /usr/src/sys/dev/pci/vga_pci.c:208: undefined reference to `x86bios_get_orm' /usr/src/sys/dev/pci/vga_pci.c:211: undefined reference to `x86bios_init_regs' /usr/src/sys/dev/pci/vga_pci.c:218: undefined reference to `x86bios_call' /usr/src/sys/dev/pci/vga_pci.c:221: undefined reference to `x86bios_get_intr' *** [kernel.debug] Error code 1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJU82ryXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b6UYH/0TN2yhOCM+PvgWf6Xhi2yYa +JcEXTMum5UZnwrrXtJKLxg/joDlXb9Af+ESpwmg3wYP+Ku3YQ8C20+VSf627JEI Zad4diaRFMO1wK2Tpcjq9lm3u96x1qQTe7z2yuKooGjX1yjT/B64CDwjteM2uraO TJq5R7dvk1r9UiwXQNUgW8pmyN9yQwbcfUpxYK4FOVnYOjg29MTVk/qifJVz6fyo oq1KsbiJNQMY5Q6sLZpo9+E+lSi+vjOvMZ3TBpwhStU/YOB+pQL39YhZQSpdMPv7 dzifISK5W6GboI1zHlCCFk3pxxfxfyD2af+xz3J9en+h4wJSOiRYYY3K+haoO5E= =EZyo -----END PGP SIGNATURE----- --=-=-=--