From owner-freebsd-current  Wed Jul 10 14:22:33 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3C13737B400; Wed, 10 Jul 2002 14:22:30 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7CCE143E58; Wed, 10 Jul 2002 14:22:28 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA15435;
	Thu, 11 Jul 2002 07:22:26 +1000
Date: Thu, 11 Jul 2002 07:25:41 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Giorgos Keramidas <keramida@FreeBSD.ORG>
Cc: Dag-Erling Smorgrav <des@FreeBSD.ORG>, <current@FreeBSD.ORG>
Subject: Re: sparc64 tinderbox failure
In-Reply-To: <20020710172346.GB1118@hades.hell.gr>
Message-ID: <20020711071853.J21320-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Wed, 10 Jul 2002, Giorgos Keramidas wrote:

> On 2002-07-10 09:58 +0000, Dag-Erling Smorgrav wrote:
> > ===> bin/chmod
> > cc1: warnings being treated as errors
> > /usr/home/des/tinderbox/sparc64/src/bin/chmod/chmod.c: In function `main':
> > /usr/home/des/tinderbox/sparc64/src/bin/chmod/chmod.c:174: warning: null format string
>
> How does this look for fixing this warning?
>
> %%%
> Index: chmod.c
> ===================================================================
> RCS file: /home/ncvs/src/bin/chmod/chmod.c,v
> retrieving revision 1.25
> diff -u -r1.25 chmod.c
> --- chmod.c	30 Jun 2002 05:13:52 -0000	1.25
> +++ chmod.c	10 Jul 2002 17:22:22 -0000
> @@ -171,7 +171,7 @@
>  	}
>
>  	if ((ftsp = fts_open(++argv, fts_options, 0)) == NULL)
> -		err(1, NULL);
> +		err(1, "%s: %s", *argv, strerror(p->fts_errno));
>  	for (rval = 0; (p = fts_read(ftsp)) != NULL;) {
>  		switch (p->fts_info) {
>  		case FTS_D:			/* Change it at FTS_DP. */
> %%%

The main bug is that the warning is emitted.  err(1, NULL) is perfectly
valid (see err(4)).  Apparently the sparc64 compiler is missing support
for __printf0like.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message