From owner-freebsd-current@FreeBSD.ORG Fri Nov 21 23:57:36 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 813761065675 for ; Fri, 21 Nov 2008 23:57:36 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from hs-out-0708.google.com (hs-out-0708.google.com [64.233.178.243]) by mx1.freebsd.org (Postfix) with ESMTP id 2A7318FC0C for ; Fri, 21 Nov 2008 23:57:35 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by hs-out-0708.google.com with SMTP id 54so572572hsz.11 for ; Fri, 21 Nov 2008 15:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=/belbTS5imAj4IIJidrjI9yvWHbjvDN6JxtdDgHHkQ4=; b=eai+EprarMJA+JCFg9/yneMNg2HbKoPa8hF0tk/R62i/GTxoD1184Ly499o8mPBrnq xlxSc1lk7AyR9mWzgpipFyhpRj5aGaCBQZTB0LOJi2fj/mjRLxcREyH9htl6cYMapBnT pyuIlXxy1qdW5kMycFNuwc9z6qOGGQNS+Tl0M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=R0w3VpK/CwttEcoie16u7TT+stlqfJFPeQNU/8djrw+03PbPCLNvo0nwpFr5zRTYIx Lwx87iCrI3i7dYwwWA8iYbAXoL6DzH0CyZ/BqLz4FfovkqMPa7XaACQMV1G6WTvDTlGZ mIX3iAY0AxkXcWuqXzRQbHsu2WB+Yow5YTdKM= Received: by 10.231.12.12 with SMTP id v12mr28072ibv.4.1227311855148; Fri, 21 Nov 2008 15:57:35 -0800 (PST) Received: by 10.231.11.7 with HTTP; Fri, 21 Nov 2008 15:57:35 -0800 (PST) Message-ID: <3a142e750811211557r75c5c3eaxaa5cd2712360c26e@mail.gmail.com> Date: Sat, 22 Nov 2008 00:57:35 +0100 From: "Paul B. Mahol" To: "Jaakko Heinonen" In-Reply-To: <20081121074013.GA818@a91-153-125-115.elisa-laajakaista.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811191510.53793.jhb@FreeBSD.org> <3a142e750811201330p3084255em390d94b352dee532@mail.gmail.com> <20081121074013.GA818@a91-153-125-115.elisa-laajakaista.fi> Cc: current@freebsd.org Subject: Re: [PATCH] MPSAFE/LOOKUP_SHARED cd9660 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2008 23:57:36 -0000 On 11/21/08, Jaakko Heinonen wrote: > On 2008-11-20, Paul B. Mahol wrote: >> Machine crashed during clean shutdown (with old kernel without this patch) >> after atapicd where kldloaded and after that used some time and tham >> kldunloaded. > > There are several bugs related to unloading the atapicd module. > > * g_wither_geom() race against module unload > * return value from g_modevent() is ignored > * detaching/unloading is allowed even if the device is in use > > You could try these patches: > > http://www.saunalahti.fi/~jh3/patches/atapi-cd-locking+tray-control.diff > http://www.saunalahti.fi/~jh3/patches/geom-unload-class-race.diff Works fine for me. With that patches panic doesnt not happen during shutdown, -- Paul