Date: Sat, 25 Mar 2006 17:28:42 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netipx ipx_pcb.c ipx_pcb.h ipx_usrreq.c spx_usrreq.c Message-ID: <200603251728.k2PHSgjO015091@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2006-03-25 17:28:42 UTC
FreeBSD src repository
Modified files:
sys/netipx ipx_pcb.c ipx_pcb.h ipx_usrreq.c
spx_usrreq.c
Log:
Rework IPX/SPX socket and pcb reference model:
- Introduce invariant that all IPX/SPX sockets will have valid so_pcb
pointers to ipxpcb structures, and that for SPX, the control block
pointer will always be valid. Don't attempt to free the socket or
pcb at various odd points, such as disconnect.
- Add a new ipxpcb flag, IPXP_DROPPED, which will be set in place of
freeing PCB's so that this invariant can be maintained. This flag
is now checked instead of a NULL check in various socket protocol
calls.
- Introduce many assertions that this invariant holds.
- Various pieces of code, such as the SPX timer code, no longer needs
to jump through hoops in case it frees a PCB while running.
- Break out ipx_pcbfree() from ipx_pcbdetach(). Likewise
spx_pcbdetach().
- Comment on some SMP-related limitations to the SPX code.
- Update copyrights.
MFC after: 1 month
Revision Changes Path
1.45 +13 -5 src/sys/netipx/ipx_pcb.c
1.25 +11 -8 src/sys/netipx/ipx_pcb.h
1.53 +22 -11 src/sys/netipx/ipx_usrreq.c
1.76 +100 -68 src/sys/netipx/spx_usrreq.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603251728.k2PHSgjO015091>