From owner-svn-ports-all@freebsd.org  Sun Jun 18 02:50:29 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E8B9D86BA9;
 Sun, 18 Jun 2017 02:50:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 75938801C1;
 Sun, 18 Jun 2017 02:50:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id D092F9D5E; Sun, 18 Jun 2017 02:50:28 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r443793 - head/lang/gcc7-devel
References: <201706172327.v5HNRbGE015821@repo.freebsd.org>
 <d1a2-9k83-wny@FreeBSD.org>
 <alpine.LSU.2.21.1706180321130.2749@anthias.pfeifer.com>
Date: Sun, 18 Jun 2017 04:50:26 +0200
In-Reply-To: <alpine.LSU.2.21.1706180321130.2749@anthias.pfeifer.com> (Gerald
 Pfeifer's message of "Sun, 18 Jun 2017 03:25:27 +0200 (CEST)")
Message-ID: <shiy-2eml-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jun 2017 02:50:29 -0000

Gerald Pfeifer <gerald@pfeifer.com> writes:

> On Sun, 18 Jun 2017, Jan Beich wrote:
>
>>>   When we set STAGE1_CXXFLAGS / CXXFLAGS in MAKE_FLAGS for arm platforms,
>>>   do so incrementally (with += instead of =).
>> Did you mean to use MAKE_ENV instead of +=?
>
> I'm not sure. ;-)  In your example, += did not actually work in
> the MAKE_ENV tests, did it?

Correct, += syntax isn't supported by sh(1) and += syntax in gmake(1)
acts differently between on command line and in a file.

> Did you mean that the commit message should have referred to
> MAKE_ARGS instead of MAKE_FLAGS?

MAKE_ARGS usage looks wrong as it discards system CXXFLAGS i.e., -O2
-fno-strict-aliasing -pipe. Replacing = with += won't fix it.

Whether there's a bug or not requires understanding the intent. With
commit messages that state only "what" was done, but not "why", one can
only guess the former. Testing can help deriving the intent but in my
case poudriere fails to create armv6 jail (unlike aarch64).

Or perhaps you can answer "Why do you need the incremental assignment?"