From owner-freebsd-ruby@FreeBSD.ORG Sun Jul 29 13:50:08 2012 Return-Path: Delivered-To: ruby@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2D061065670; Sun, 29 Jul 2012 13:50:08 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) by mx1.freebsd.org (Postfix) with ESMTP id C3B158FC0A; Sun, 29 Jul 2012 13:50:06 +0000 (UTC) Received: from [IPv6:2001:470:8:58f:15f6:c36a:f641:6022] ([IPv6:2001:470:8:58f:15f6:c36a:f641:6022]) (authenticated bits=0) by mouf.net (8.14.5/8.14.5) with ESMTP id q6TDn69w082727 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 29 Jul 2012 09:49:08 -0400 (EDT) (envelope-from swills@FreeBSD.org) References: <501483B6.6080905@FreeBSD.org> In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <72BA465B-2161-4ED7-9946-5A3D1F949B4B@FreeBSD.org> X-Mailer: iPad Mail (9B206) From: Steve Wills Date: Sun, 29 Jul 2012 09:50:00 -0400 To: Stanislav Sedov X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]); Sun, 29 Jul 2012 09:49:08 -0400 (EDT) X-Spam-Status: No, score=1.3 required=4.5 tests=RDNS_NONE autolearn=no version=3.3.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mouf.net X-Virus-Scanned: clamav-milter 0.97.5 at mouf.net X-Virus-Status: Clean Cc: "ruby@freebsd.org" Subject: Re: patching rubygems X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2012 13:50:08 -0000 On Jul 28, 2012, at 10:08 PM, Stanislav Sedov wrote: > Thanks for the patch! I like the idea, though I'm not sure if it makes > sense to unpack all the gems we build. Won't it be better to unpack > just those gems we have patches for, and use the old code path for > gems that do not require patching? Perhaps, but I think there's also some value in doing them all the same way i= f possible, for the sake of simplicity. Also, I'm not sure of an easy way to= tell if a port has patches or not. I'd hate to have to add a variable to sp= ecify patching. Am I missing something existing that I can use for this? > Also, I don't really like the "rm -rf $WRKDIR" line. It looks scary. > Is it necessary to delete it and create it again? Besides, WRKDIR > should probably be quoted, otherwise bad things might happen if it > contains spaces (and probably all of the other variables too). I wrote most of this a while ago and can't even remember why I had that in t= here. Taking it and the next line out seemed to have no ill effects. Steve