From nobody Tue Apr 4 18:18:22 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Prbc532fXz43y2H; Tue, 4 Apr 2023 18:18:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Prbc51sK2z466Z; Tue, 4 Apr 2023 18:18:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id jiKmpvksTjvm1jlEhpjetM; Tue, 04 Apr 2023 18:18:27 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id jlEepamvk3fOSjlEgpLbQ9; Tue, 04 Apr 2023 18:18:27 +0000 X-Authority-Analysis: v=2.4 cv=J8G5USrS c=1 sm=1 tr=0 ts=642c69f3 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=dKHAf1wccvYA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=pGLkceISAAAA:8 a=-oQlTjAZ4b4Avn3B72IA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 53E99254; Tue, 4 Apr 2023 11:18:23 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 0EA79C4; Tue, 4 Apr 2023 11:18:22 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mateusz Guzik cc: Cy Schubert , Martin Matuska , Rick Macklem , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled In-reply-to: References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <20230404093418.3041ff23@slippy> Comments: In-reply-to Mateusz Guzik message dated "Tue, 04 Apr 2023 20:10:50 +0200." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 04 Apr 2023 11:18:22 -0700 Message-Id: <20230404181823.0EA79C4@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLQjcnQtr4n1ft4m1qprFuQAJr+99UoCJ2F39hANe1SyDt/MzK1PL0EvTIaTGZINPyFvO5a+M+DAmrYOlUR+n6nDQcwSYttriUukmBGrIrX+d/I5wk/I UTgoZdyrB1E/UIOFk+fa+HreA6Z976NBCHKhsB6mDJ2UhKpbf8SnsZubTstXKsWjwpJUesc7q+RYpF8ht629NZCxVnMGiDs4664uryYmxpuK0Qvn8dRDGZEP tTnAeoy/W9zmvN7eFefQZ5Q2BQvJt8808/4LfeCLoWuYwZBvBgCoapM/j38mjgMkEmrzAjlOgKzjnTaNTjPU1U1HZ8ECAaP512xcSniDoXrgu4QCeoEJE9KB z/uCDHna2EylClJN/6OWVcftqlkt58DsH0MX5IxhqfYnDA5m5/4= X-Rspamd-Queue-Id: 4Prbc51sK2z466Z X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message , Mateusz Guzik writes: > can you please post a review I could but I didn't write any of it. Rick Macklem and Martin Matuska wrote it. My patch was for discussion only. Martin and Rick, do you mind if I post this as a review. It should probably be two, maybe three separate commits, fixing two different problems. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0 > > On 4/4/23, Cy Schubert wrote: > > The previously posted patch containing the following fixes all > > regressions discussed so far: > > > > - Rick's fix null ap->a_fsizetd NULL pointer derefernce > > - Rick's call vn_generic_copy_file_range() when block_cloning is > > disabled > > - Martin's call vn_generic_copy_file_range() when any other error > > resulting in EXDEV > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: https://FreeBSD.org > > NTP: Web: https://nwtime.org > > > > e^(i*pi)+1=0 > > > > > > On Tue, 4 Apr 2023 09:18:44 -0700 > > Cy Schubert wrote: > > > >> On Tue, 4 Apr 2023 17:30:25 +0200 > >> Martin Matuska wrote: > >> > >> > So I am now a little bit confused - what is the consensus? :-) > >> > >> My exmh email client made a mess of that. Let's try this again. > >> > >> Rick has posted a patch. Your patch should also be incorporated to work > >> around other EXDEV errors, but a few lines earlier so it is protected by > >> the lock. > >> > >> There were a couple of typos in Rick's patch (a missing keystroke; > >> s/ojset/objset/). > >> > >> The patch (Rick's null pointer dereference fix, Rick's copy file range > >> patch plus your copy file range patch) builds fine on amd64 and i386. > >> Installing and testing it now. > >> > >> A combination of all three patches is attached. It's compile tested but is > >> > >> currently being installed and will be tested when install is completed. > >> > > > > > > > -- > Mateusz Guzik