From owner-cvs-all  Wed Jan 24  9:37:20 2001
Delivered-To: cvs-all@freebsd.org
Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2393D37B402; Wed, 24 Jan 2001 09:36:56 -0800 (PST)
Received: (from bright@localhost)
	by fw.wintelcom.net (8.10.0/8.10.0) id f0OHatX12850;
	Wed, 24 Jan 2001 09:36:55 -0800 (PST)
Date: Wed, 24 Jan 2001 09:36:55 -0800
From: Alfred Perlstein <bright@wintelcom.net>
To: John Baldwin <jhb@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/linux linux_machdep.c linux_sysvec.c
Message-ID: <20010124093655.W26076@fw.wintelcom.net>
References: <200101241026.f0OAQD707387@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200101241026.f0OAQD707387@freefall.freebsd.org>; from jhb@FreeBSD.org on Wed, Jan 24, 2001 at 02:26:13AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

* John Baldwin <jhb@FreeBSD.org> [010124 02:28] wrote:
> jhb         2001/01/24 02:26:13 PST
> 
>   Modified files:
>     sys/alpha/linux      linux_machdep.c linux_sysvec.c 
>   Log:
>   Proc locking.

This looks like another natural race condition:

        int     p_sigparent;            /* (c) Signal to parent on exit. */

Can't int assignments be assumed to be atomic?

+       PROC_LOCK(p);
        p2->p_sigparent = exit_signal;
+       PROC_UNLOCK(p);

-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message