Date: Mon, 25 Sep 2017 15:02:12 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Russell Haley <russ.haley@gmail.com>, freebsd-ports@freebsd.org, doc@freebsd.org Subject: Re: Porters Handbook section 4.4 Message-ID: <8a3e663a-d94f-0ef7-bbc7-8ebaa111f6dd@FreeBSD.org> In-Reply-To: <CABx9NuSC=tVieJ=dk6%2BFucvfEfNGHCRMuHcy%2BNxo9QW%2BtS8-gA@mail.gmail.com> References: <CABx9NuSC=tVieJ=dk6%2BFucvfEfNGHCRMuHcy%2BNxo9QW%2BtS8-gA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/25/17 2:08 PM, Russell Haley wrote: > Hi, > > Section 4.3 of the porters handbook talks about making modifications > to a private copy of a tarball and recording the steps. > > Section 4.4 talks about changing directories into the affected ports > dir and running make makepatch to generate patch files. > > I am unsure how the makepatch target is supposed to find my private > directory. Since I was confused, I created patches, added them to the > port, ran make, then ran make makepatch and the system re-generated > new "makepatch" patches. Quite a number of new users have raised the same question on IRC. > So, my question is thus: > > To me, section 4.4 seems vague about where changes should be made, > which is compounded by the information in section 4.3. Can the > makepatch target ask for and find a private directory, or should the > handbook be clarified to state that the changes should be made to the > 'work' folder? If the later is true, I assume there is some proper > workflow to keep changes from being destroyed while testing? The handbook section needs to be updated to be less ambiguous with regard to where things should be done. I'd be happy to provide a docs committer with verbiage if they can help with formatting/commit. > If there is a section in the handbook clarifying this, please just say > so and I will go find it. > > Thanks! > Russ ./koobs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8a3e663a-d94f-0ef7-bbc7-8ebaa111f6dd>