From owner-freebsd-arch@FreeBSD.ORG Tue Nov 8 00:54:30 2005 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B1CD16A41F; Tue, 8 Nov 2005 00:54:30 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EAE843D48; Tue, 8 Nov 2005 00:54:29 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id jA80qWUk012587; Mon, 7 Nov 2005 17:52:32 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 07 Nov 2005 17:52:59 -0700 (MST) Message-Id: <20051107.175259.13769963.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <436FD47D.2000802@samsco.org> References: <20051107194424.GA35394@stack.nl> <200511071635.39323.jhb@freebsd.org> <436FD47D.2000802@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 07 Nov 2005 17:52:33 -0700 (MST) Cc: freebsd-arch@freebsd.org, ed@fxq.nl, rink@stack.nl Subject: Re: FreeBSD/xbox: updated 7.0 patchset X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2005 00:54:30 -0000 In message: <436FD47D.2000802@samsco.org> Scott Long writes: : John Baldwin wrote: : : > On Monday 07 November 2005 02:44 pm, Rink Springer wrote: : > : >>Hi, : >> : >>OK, I've updated the patchset. Changes: : >> : >>- opt_xbox.h is now used instead of opt_global.h : >>- xboxfb.c should follow style(9) better : >>- boot_font.c is no longer patched : >>- 128MB XBOX-es should work too [1] : >> : >>It is fetchable from : >>http://rink.nu/downloads/xbox-patches/xbox-7-current.v2.diff : >> : >>Oh, and for John's comment: The reason pic16l.s is coded in assembly, was : >>that it was used extensively while debugging (it even resided in : >>locore.s for a while :-), as being able to change the LED's color is : >>immensely useful if you don't have a framebuffer working already :) This : >>is why I'd prefer to keep this file as-is. : > : > : > You do realize that you can call C functions from assembly, right? :) : > : : If this is the only remaining technical objection, then can it be : something that gets resolved after it goes into the tree? It's code : that is segregated and private to the XBOX port, so it would be a shame : to make it stall this great work. Don't worry. I have v1 of the patches sitting in a tree waiting for me to find some time to commit them. I was going to update to v2 tonight and see what had been fixed and integrate more into it either tonight or tomorrow night. Warner