From owner-freebsd-current@FreeBSD.ORG Fri Nov 17 18:13:26 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5074416A403 for ; Fri, 17 Nov 2006 18:13:26 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6229B43D53 for ; Fri, 17 Nov 2006 18:13:24 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAHIDHkE028093; Fri, 17 Nov 2006 11:13:22 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455DFBBB.7020307@samsco.org> Date: Fri, 17 Nov 2006 11:13:15 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: Mark Atkinson References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: freebsd-current@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 18:13:26 -0000 Mark Atkinson wrote: > (moving to current to avoid dirtying src further) > > John Baldwin wrote: >> jhb 2006-11-15 20:04:57 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/bce if_bce.c >> sys/dev/em if_em.c if_em.h >> sys/dev/mpt mpt.h mpt_pci.c >> Log: >> Add MSI support to em(4), bce(4), and mpt(4). For now, we only support >> devices that support a maximum of 1 message, and we use that 1 message >> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. >> >> Revision Changes Path >> 1.19 +11 -3 src/sys/dev/bce/if_bce.c >> 1.164 +11 -2 src/sys/dev/em/if_em.c >> 1.56 +1 -0 src/sys/dev/em/if_em.h >> 1.31 +1 -0 src/sys/dev/mpt/mpt.h >> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c >> _______________________________________________ >> cvs-src@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/cvs-src >> To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > This is great, I don't know if you plan on adding MSI support to all network > drivers that could support it, but here's the output from the Tyan S2895 > (k8WE) for the nve0 and nve1 devices, which report supporting 2 messages. > The challenge is knowing what meaning the chip assigns to each of those messages, as well as knowing what errata come with it. It's not just a mechanical code change to the driver. You could always try the simple route with only allocating a single message, but you'd then have to make sure that it actually works reliably for everyone. Scott