From owner-svn-src-all@FreeBSD.ORG Wed Nov 26 21:15:08 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80AB21065677; Wed, 26 Nov 2008 21:15:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 311728FC25; Wed, 26 Nov 2008 21:15:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 51F7D41C64A; Wed, 26 Nov 2008 22:15:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id Ij8SpCstRbW2; Wed, 26 Nov 2008 22:15:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id F173041C67B; Wed, 26 Nov 2008 22:15:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 7A00E4448D5; Wed, 26 Nov 2008 21:14:34 +0000 (UTC) Date: Wed, 26 Nov 2008 21:14:33 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Max Laier In-Reply-To: <200811262208.48429.max@love2party.net> Message-ID: <20081126211242.T61259@maildrop.int.zabbadoz.net> References: <200811262052.mAQKqRN5065921@svn.freebsd.org> <200811262208.48429.max@love2party.net> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185344 - in head/sys: netinet netinet6 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2008 21:15:08 -0000 On Wed, 26 Nov 2008, Max Laier wrote: > On Wednesday 26 November 2008 21:52:27 Bjoern A. Zeeb wrote: >> Author: bz >> Date: Wed Nov 26 20:52:26 2008 >> New Revision: 185344 >> URL: http://svn.freebsd.org/changeset/base/185344 >> >> Log: >> Remove in6_pcbdetach() as it is exactly the same function >> as in_pcbdetach() and we don't need the code twice. >> >> Reviewed by: rwatson >> MFC after: 6 weeks (*) >> (*) possibly need to leave a stub wrapper in 7 to keep the symbol. > > Won't this affect our ability to build INET6, but non INET kernels? Not that > we currently could, but if we ever wanted to? Nope. though maybe for the moment. The point is if you go by that argument you would have to duplicate half of the network stack. The trick will be to hide the IPv4 only parts with #ifdef INET in the next step and compile the common code optional inet || inet6 but I need to check our build foo and it'll be a long way there anyway... -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.