Date: Thu, 25 Sep 2014 18:02:44 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193931] New: [exp-run] always define *_ARGS for USES entries Message-ID: <bug-193931-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193931 Bug ID: 193931 Summary: [exp-run] always define *_ARGS for USES entries Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Infrastructure Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: tijl@FreeBSD.org Created attachment 147676 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147676&action=edit patch The attached patch is a proposal to change the handling of USES in bsd.port.mk such that for every u in USES u_ARGS is always defined, and, has commas replaced with spaces. It also loops over USES twice. Once to define all u_ARGS and once to include Uses/u.mk. This makes all u_ARGS available to all Uses/u.mk which can be used in autoreconf.mk for instance to examine gettext_ARGS and libtool_ARGS. The changes for _USES_POST are similar but here u_ARGS is only defined if it isn't defined yet (it wasn't in USES), or if there are new arguments. The patch then adjust all Uses/*.mk: - defined(u_ARGS) becomes !empty(u_ARGS) - eliminate helper variables like _u_ARGS=${u_ARGS:C/,/ /g} - Some Uses/*.mk used ":" as argument separator instead of ",", but no port uses this at the moment - Uses/cran.mk: remove unused variable VALID_ARGS and USES+=fortran which has no effect - Uses/twisted.mk: simplify handling of the case where neither "build" nor "run" arguments have been specified -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193931-13>