From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Sep 25 18:02:44 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F2098689 for ; Thu, 25 Sep 2014 18:02:44 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE57293B for ; Thu, 25 Sep 2014 18:02:44 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8PI2i12017978 for ; Thu, 25 Sep 2014 18:02:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193931] New: [exp-run] always define *_ARGS for USES entries Date: Thu, 25 Sep 2014 18:02:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Infrastructure X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tijl@FreeBSD.org X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2014 18:02:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193931 Bug ID: 193931 Summary: [exp-run] always define *_ARGS for USES entries Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Infrastructure Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: tijl@FreeBSD.org Created attachment 147676 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147676&action=edit patch The attached patch is a proposal to change the handling of USES in bsd.port.mk such that for every u in USES u_ARGS is always defined, and, has commas replaced with spaces. It also loops over USES twice. Once to define all u_ARGS and once to include Uses/u.mk. This makes all u_ARGS available to all Uses/u.mk which can be used in autoreconf.mk for instance to examine gettext_ARGS and libtool_ARGS. The changes for _USES_POST are similar but here u_ARGS is only defined if it isn't defined yet (it wasn't in USES), or if there are new arguments. The patch then adjust all Uses/*.mk: - defined(u_ARGS) becomes !empty(u_ARGS) - eliminate helper variables like _u_ARGS=${u_ARGS:C/,/ /g} - Some Uses/*.mk used ":" as argument separator instead of ",", but no port uses this at the moment - Uses/cran.mk: remove unused variable VALID_ARGS and USES+=fortran which has no effect - Uses/twisted.mk: simplify handling of the case where neither "build" nor "run" arguments have been specified -- You are receiving this mail because: You are the assignee for the bug.