From owner-p4-projects@FreeBSD.ORG  Fri May  7 21:15:38 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 341A416A4D0; Fri,  7 May 2004 21:15:38 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0A35A16A4CE
	for <perforce@freebsd.org>; Fri,  7 May 2004 21:15:38 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 5B9F343D5F
	for <perforce@freebsd.org>; Fri,  7 May 2004 21:15:37 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 51955 invoked by uid 1000); 8 May 2004 04:15:39 -0000
Date: Fri, 7 May 2004 21:15:39 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200405031911.i43JBPk7000313@repoman.freebsd.org>
Message-ID: <20040507211416.H51922@root.org>
References: <200405031911.i43JBPk7000313@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 52156 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 May 2004 04:15:38 -0000

On Mon, 3 May 2004, John Baldwin wrote:
> http://perforce.freebsd.org/chv.cgi?CH=52156
>
> Change 52156 by jhb@jhb_slimer on 2004/05/03 12:10:39
>
> 	Bah, revert accidental submits.  Neither of these worked on my
> 	laptop, though the acpi_video one does work for some people and
> 	might should be committed.
>
> Affected files ...
>
> .. //depot/projects/power/sys/dev/acpica/acpi_video.c#4 edit
> .. //depot/projects/power/sys/isa/vga_isa.c#5 edit

The DPMS stuff should go in a different device driver than acpi_video.  It
is a MI driver that implements only the standard ACPI interfaces.  DPMS is
probed separately and should be in a separate driver.  You can have DPMS
without ACPI too.

-Nate