From owner-svn-src-all@FreeBSD.ORG  Thu Apr 14 21:34:38 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4AEDE1065670;
	Thu, 14 Apr 2011 21:34:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 218948FC0C;
	Thu, 14 Apr 2011 21:34:38 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id C6E7546B0D;
	Thu, 14 Apr 2011 17:34:37 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 50F868A027;
	Thu, 14 Apr 2011 17:34:37 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kib@freebsd.org>
Date: Thu, 14 Apr 2011 17:13:28 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; )
References: <201104101707.p3AH736T054347@svn.freebsd.org>
In-Reply-To: <201104101707.p3AH736T054347@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201104141713.28311.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Thu, 14 Apr 2011 17:34:37 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r220526 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Apr 2011 21:34:38 -0000

On Sunday, April 10, 2011 1:07:03 pm Konstantin Belousov wrote:
> Author: kib
> Date: Sun Apr 10 17:07:02 2011
> New Revision: 220526
> URL: http://svn.freebsd.org/changeset/base/220526
> 
> Log:
>   Some callers of proc_reparent() already have the parent process locked.
>   Detect the situation and avoid process lock recursion.
>   
>   Reported by:	Fabian Keil <freebsd-listen fabiankeil de>
> 
> Modified:
>   head/sys/kern/kern_exit.c

Can we instead assert it is always held and fix callers that don't?  Using 
locked variables is messy and I'd rather avoid it when possible.  We already 
require the caller to hold other locks for this operation.

-- 
John Baldwin