Date: Thu, 14 Apr 2011 17:13:28 -0400 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r220526 - head/sys/kern Message-ID: <201104141713.28311.jhb@freebsd.org> In-Reply-To: <201104101707.p3AH736T054347@svn.freebsd.org> References: <201104101707.p3AH736T054347@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, April 10, 2011 1:07:03 pm Konstantin Belousov wrote: > Author: kib > Date: Sun Apr 10 17:07:02 2011 > New Revision: 220526 > URL: http://svn.freebsd.org/changeset/base/220526 > > Log: > Some callers of proc_reparent() already have the parent process locked. > Detect the situation and avoid process lock recursion. > > Reported by: Fabian Keil <freebsd-listen fabiankeil de> > > Modified: > head/sys/kern/kern_exit.c Can we instead assert it is always held and fix callers that don't? Using locked variables is messy and I'd rather avoid it when possible. We already require the caller to hold other locks for this operation. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104141713.28311.jhb>