From owner-cvs-ports@FreeBSD.ORG Thu Jan 12 13:38:19 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 119001065675; Thu, 12 Jan 2012 13:38:19 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45]) by mx1.freebsd.org (Postfix) with ESMTP id CEACE8FC0A; Thu, 12 Jan 2012 13:38:18 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id D67905C3A; Thu, 12 Jan 2012 08:38:17 -0500 (EST) Date: Thu, 12 Jan 2012 08:38:17 -0500 From: Wesley Shields To: Michael Scheidell Message-ID: <20120112133817.GA52741@atarininja.org> References: <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org> <4F0CC4DF.6030906@FreeBSD.org> <4F0ED9F1.20305@FreeBSD.org> <4F0EDE0C.8020005@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F0EDE0C.8020005@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Doug Barton , raven428@gmail.com, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Greg Larkin , Gabor Kovesdan , cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 13:38:19 -0000 On Thu, Jan 12, 2012 at 08:20:12AM -0500, Michael Scheidell wrote: > > > On 1/12/12 8:02 AM, Gabor Kovesdan wrote: > > Although compatible, MariaDB is not MySQL. From the user perspective I > > definitely would not want such behavior. I'd rather vote for adding > > extra knobs for that. > > > I like knobs.. I push maintainers and submitters to include option > knobs, especially when their port does a *_DEPENDS on something that not > everyone will want. > > I would ASSUME, if user has 'USE_MYSQL=52' in the make.conf or env, they > have made that selection. Just a quick note for anyone who reads this: Users should _NEVER_ set USE_* in /etc/make.conf. http://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#USE-VARS -- WXS