From owner-dev-commits-src-main@freebsd.org Fri Apr 9 20:57:57 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70E415BD30B for ; Fri, 9 Apr 2021 20:57:57 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FH9Sj2PWfz4cYP for ; Fri, 9 Apr 2021 20:57:57 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f46.google.com with SMTP id e12so6837435wro.11 for ; Fri, 09 Apr 2021 13:57:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1aDzDssqkziorV+eGjbWdSfG1hzgfPCqT4LJx6+DVYY=; b=jAzJsiHNDgEcuWXfjF0XeEgdr69OSitCOg1Z8U+gXLvuId5MOSnV0a3W0Jb5NUaimY 9Lw7TlHcx3evKOEnfIKzyfh+PlQ8iC7kFm8OUwVvVnXnToDaw+u0z1DeLVLUMF2/Glew m5Qf7jq1B5yTZVqh/u6EOb/zp6de/b2VfswhN6fgJ/gQ9NTj6h3v8tlgkRNxuQfEDwqk VKLjPtGFqB5Iu4W2v3XjPJ2fo0FuSf8/85HE2vjkxL7kno11BGW1F2MrmLSyrKGGI/lq 9hSKY7dkQaMzRfV6dYkvSKCp4V7PeV3N49iRQBHHM2D7fvu42nqTL1ZhhPPoLYEWeAVp BhvA== X-Gm-Message-State: AOAM533OS5GoILOjLp/DAGZJ1enrpvKROuHaTxuK5azcSsij2O/89ASO 7SlqExtJkGgzRwxNpcCI58JZT5WSRfCPn7xa X-Google-Smtp-Source: ABdhPJzCyT3fNJnxrzQxQsOnVi7Vq2x8XIS+FrBt1aTuRzazSqznIbEz8mDf8d5kQladOuZAzGnfBA== X-Received: by 2002:a5d:6b50:: with SMTP id x16mr19049661wrw.379.1618001875961; Fri, 09 Apr 2021 13:57:55 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id h2sm5939983wmc.24.2021.04.09.13.57.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Apr 2021 13:57:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: git: 06d8a116bd6b - main - libc: add _get_tp() private function From: Jessica Clarke In-Reply-To: <202104092047.139KlBo3071549@gitrepo.freebsd.org> Date: Fri, 9 Apr 2021 21:57:55 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0@freebsd.org> References: <202104092047.139KlBo3071549@gitrepo.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Rspamd-Queue-Id: 4FH9Sj2PWfz4cYP X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 20:57:57 -0000 On 9 Apr 2021, at 21:47, Konstantin Belousov wrote: >=20 > The branch main has been updated by kib: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D06d8a116bd6b6f70b8aedc6a6a2c4085= c53f63ac >=20 > commit 06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac > Author: Konstantin Belousov > AuthorDate: 2021-04-05 03:30:35 +0000 > Commit: Konstantin Belousov > CommitDate: 2021-04-09 20:46:24 +0000 >=20 > libc: add _get_tp() private function >=20 > which returns pointer to tcb This feels like it should be static inline in a header. Also we already = have _tcb_get in pthread_md.h that should be entirely equivalent, and _libc_get_static_tls_base that=E2=80=99s basically the same again but = with an optional offset. Can we do something to unify all the inline asm into one place = per architecture rather than growing yet more copies of the same thing? Jess