From nobody Fri Jul 24 11:12:34 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h651Z5HRRz6lhH3 for ; Fri, 24 Jul 2026 11:12:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h651Z4k4Tz4Ncq for ; Fri, 24 Jul 2026 11:12:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784891554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yTCmIE1jbR0/5rQMOnr/QhXhdrj0jxegr9g6fbpmJxE=; b=hhNwGWpcPax7WdtFU/uOevscidpZ5Fv7bMkssYVuEn/dNMIajtln2ztO3XeeUgue8nOrAO be57lwIZ1gQ39hLgO8ygRwSOv+dNnNMlL5JxZ61coWyzYhvc3pxlj8Iea1/SLcfjZMVkkH tIOUCr4uFWb5Cq138Zdi58pnrFzawk+FiqKZAmbpLSDsvUdcbADsoHToPxfVcrZ6gE/7SZ skr3XaTYE2vtUquBHc3DHmQvf+yuM+gMd2rgqE7xMHokEtZx7ByajG8GPdt7yD9Lc2I3Kh 4LX6fDZBGV8ixmYIX0ORGZTkM6KYUxe6fxioSAJgk+zjA7v479/czn3XLbkhUA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784891554; a=rsa-sha256; cv=none; b=ux0txIWUABq3n271PBfqv/pNdvkGM0VfCBeyq9B9ZJ9j1yZuiHjXCuGsKcz2hZm7Brvvv6 O8J7/84+G39lK7aYdLDgc3t9Ju9oo7+/Of93FoLsagTfrQmoMTB4sH8RXEeP4lYTMxNo61 ohhkhihjZLpvO5igc4suFSNUVtswHg17FG+3dZE1gUAl7DM1k81BGXVSZobDDVMCGoymuj OwF6mdWn1VLVcUrlpEam/ELTVpsl5muiIwImnqi/Lef7ehdwdw6Hp/lKd6uSDW75WhiEpt WgKhGfvVJ78IZxgcCnxD5i8lcPVzUdjFpcInQHRIMZAyEPpYplO482HqXBwY9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784891554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yTCmIE1jbR0/5rQMOnr/QhXhdrj0jxegr9g6fbpmJxE=; b=GiuplTyGRco+Js0+PGeQCbXqlALHcy+D8L1DIbV0U37Up1P99SJMPRN/hSoUzfUKesu+9e 4756N1dZoYOnGnnLW/XSlD239kYLvHLwP6uJrz7EX2NJWeJxoEO5U1JM8EYXqgFi8vcpS2 vBZf/7AkzoXOjZqLO5Lup2maFTMasbhXaWsBQBuQ43on++c5SYOK938H5NQ0B2F3PYRzjy DF+NF43SUEzB3yaipU/VjyfigGhb0XWNy+XJMqcxu3h5AT8pXsRnhbD/VHnXH4N82K9UvL iEdiYwL5XR6+hCjYkNBXn+Q5U6NB+2+JJSXCnIZ+pksADZIvM1FbBYT7aZv2Sg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h651Z3crXzpmx for ; Fri, 24 Jul 2026 11:12:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 451b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Jul 2026 11:12:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: daf57eb11505 - main - icmp: Verify redirect gateway with fib-aware ifa selection List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: daf57eb115053613d01e338b9022db16c045f033 Auto-Submitted: auto-generated Date: Fri, 24 Jul 2026 11:12:34 +0000 Message-Id: <6a6348a2.451b1.11c16ef1@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=daf57eb115053613d01e338b9022db16c045f033 commit daf57eb115053613d01e338b9022db16c045f033 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-07-23 09:10:32 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-07-24 08:04:27 +0000 icmp: Verify redirect gateway with fib-aware ifa selection During call to `icmp_verify_redirect_gateway()` ensure using fib-aware source address selection function. Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D58409 --- sys/netinet/ip_icmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c index adf69c47aed5..fd1a3cd24c8f 100644 --- a/sys/netinet/ip_icmp.c +++ b/sys/netinet/ip_icmp.c @@ -965,8 +965,7 @@ icmp_verify_redirect_gateway(struct sockaddr_in *src, struct sockaddr_in *dst, if ((ifa = ifa_ifwithnet((struct sockaddr *)gateway, 0, fibnum))==NULL) return (ENETUNREACH); - /* TODO: fib-aware. */ - if (ifa_ifwithaddr_check((struct sockaddr *)gateway)) + if (ifa_ifwithaddr_fib_check((struct sockaddr *)gateway, fibnum)) return (EHOSTUNREACH); nh = fib4_lookup(fibnum, dst->sin_addr, 0, NHR_NONE, 0);