Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Dec 2012 12:41:11 +0100
From:      Pietro Cerutti <gahr@FreeBSD.org>
To:        Cy Schubert <cy@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308201 - head/mail/exmh2
Message-ID:  <20121204114110.GC5906@gahrfit.gahr.ch>
In-Reply-To: <201212040621.qB46L5j6080559@svn.freebsd.org>
References:  <201212040621.qB46L5j6080559@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--1SQmhf2mF2YjsYvc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2012-Dec-04, 06:21, Cy Schubert wrote:
> Author: cy
> Date: Tue Dec  4 06:21:05 2012
> New Revision: 308201
> URL: http://svnweb.freebsd.org/changeset/ports/308201
>=20
> Log:
>   Use TCL/Tk 8.6. This fixes issues with the mail messages list "More..."
>   button.
>  =20
>   Assume care and feeding of this port.
>  =20
>   Feature safe:	yes
>=20
> Modified:
>   head/mail/exmh2/Makefile
>=20
> Modified: head/mail/exmh2/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/mail/exmh2/Makefile	Tue Dec  4 06:18:16 2012	(r308200)
> +++ head/mail/exmh2/Makefile	Tue Dec  4 06:21:05 2012	(r308201)
> @@ -14,7 +14,7 @@ CATEGORIES+=3D	mail tk
>  MASTER_SITES=3D	${MASTER_SITE_TCLTK} \
>  		SF
> =20
> -MAINTAINER?=3D	ports@FreeBSD.org
> +MAINTAINER?=3D	cy@FreeBSD.org
>  COMMENT?=3D	X11/TK based mail reader front end to MH
> =20
>  .if defined(JAPANESE_EXMH)
> @@ -23,10 +23,10 @@ BUILD_DEPENDS=3D	tclsh8.0jp:${PORTSDIR}/ja
>  WISH=3D		wish8.0jp
>  TCLSH=3D		tclsh8.0jp
>  .else
> -RUN_DEPENDS=3D	wish8.5:${PORTSDIR}/x11-toolkits/tk85
> -BUILD_DEPENDS=3D	tclsh8.5:${PORTSDIR}/lang/tcl85
> -WISH=3D		wish8.5
> -TCLSH=3D		tclsh8.5
> +RUN_DEPENDS=3D	wish8.6:${PORTSDIR}/x11-toolkits/tk86
> +BUILD_DEPENDS=3D	tclsh8.6:${PORTSDIR}/lang/tcl86
> +WISH=3D		wish8.6
> +TCLSH=3D		tclsh8.6
>  .endif

Might I suggest the following patch here?

=3D=3D BEGIN PATCH =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D
Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- Makefile	(revision 308234)
+++ Makefile	(working copy)
@@ -23,10 +23,7 @@
 WISH=3D		wish8.0jp
 TCLSH=3D		tclsh8.0jp
 .else
-RUN_DEPENDS=3D	wish8.6:${PORTSDIR}/x11-toolkits/tk86
-BUILD_DEPENDS=3D	tclsh8.6:${PORTSDIR}/lang/tcl86
-WISH=3D		wish8.6
-TCLSH=3D		tclsh8.6
+USE_TK=3D		86
 .endif
=20
 # exmh is pretty useless without this, but it's not needed to build it.
@@ -55,7 +52,7 @@
=20
 do-build:
 	@cd ${WRKSRC} && ${SETENV} PREFIX=3D${PREFIX} TCLSH=3D${TCLSH} \
-		WISH=3D${PREFIX}/bin/${WISH} WRKSRC=3D${WRKSRC} \
+		WISH=3D${WISH} WRKSRC=3D${WRKSRC} \
 		${SCRIPTS_ENV} ${SH} ${SCRIPTDIR}/build
=20
 do-install:
=3D=3D END PATCH =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Moreover, I've seen that 2.8.0 is out. It's buildable as long as you

D       files/patch-lib-folder.tcl
D       files/patch-lib-quote.tcl
D       files/patch-lib-uri.tcl

Unfortunately I'm not familiar enough with the interface to properly
run-test it.

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--1SQmhf2mF2YjsYvc
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlC94VYACgkQwMJqmJVx944hmACggBz0m2U7rMYA26fWj+hbP5TE
pgMAniVMiWeGjSIr7Wbjo9HL7i0DbEyC
=8Gdr
-----END PGP SIGNATURE-----

--1SQmhf2mF2YjsYvc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121204114110.GC5906>