From owner-cvs-all@FreeBSD.ORG Wed Jan 9 17:34:06 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9848D16A417; Wed, 9 Jan 2008 17:34:06 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 63EC313C44B; Wed, 9 Jan 2008 17:34:06 +0000 (UTC) (envelope-from sam@errno.com) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m09HY4GC092169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 9 Jan 2008 09:34:05 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <4785058B.1050507@errno.com> Date: Wed, 09 Jan 2008 09:34:03 -0800 From: Sam Leffler User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: obrien@FreeBSD.org References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> In-Reply-To: <20080109170850.GA27993@dragon.NUXI.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist Cc: Max Laier , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2008 17:34:06 -0000 David O'Brien wrote: > On Tue, Jan 08, 2008 at 10:31:49PM -0800, Peter Wemm wrote: > >> 2) merge conflicts cause everybody pain. It is no fun getting 100 conflicts >> because somebody just did a de-__P() sweep. >> >> Having said that, we have grown overly sensitive to both 1) and 2). >> > > I agree. We seem to have become overly sensitive (and grown some > assumption of some "rules") > > I note I did not complain when sys/agp was gratitiously renamed to > sys/dev/agp from sys/pci. I had local changes that I had to move to new > files and fixup afterwards. I didn't complain.. maybe I should have? > What feature did that rename give? Nothing - just a "style" change. > > > >> For what its worth, I'm glad it was cleaned up. >> > > Its funny the amount of concern being generated over something that > everyone that has said something says they are happy with. :-) > > The flip side of this is that I just tried to resolve some compile issues with netstat in the RELENG_7 branch and diff's against HEAD hit all the gratuitous "style changes" you recently made. I believe changes like this are fine when actively working in a particular area of code; but all this "knob polishing" is more likely to introduce bugs than improve the state of the code. If this is a precursor to you pitching in to improve the ipv6 code then great. I observe that netbsd does these sorts of changes in sweeps over the tree and w/ multiple people involved to review each other's work. I'd be more confident if I saw commits like this include a "Reviewed by:" line. Sam