From owner-svn-src-all@FreeBSD.ORG Wed Jul 18 12:11:11 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5B18E106566C; Wed, 18 Jul 2012 12:11:11 +0000 (UTC) (envelope-from SRS0=YLKP=FT=FreeBSD.org=brueffer@srs.kundenserver.de) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.8]) by mx1.freebsd.org (Postfix) with ESMTP id DE6878FC15; Wed, 18 Jul 2012 12:11:10 +0000 (UTC) Received: from ip235-179.wireless.lu.se (ip235-179.wireless.lu.se [130.235.235.179]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MXkt1-1TKw2s2MXn-00WpcS; Wed, 18 Jul 2012 14:11:09 +0200 Message-ID: <5006A7DD.9050509@FreeBSD.org> Date: Wed, 18 Jul 2012 14:11:09 +0200 From: Christian Brueffer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: attilio@FreeBSD.org References: <201207162207.q6GM7UNS087234@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:Vshiz7BgukA1eHZHCbKTUE1zmWwc0mSn9thh6BwP20/ uXt8jsQvQbvcDwkw3xKtKTzNhF6fEN0+H3Ha4SM3ZJOOJaoIkQ COldzH1HlcHh0yRGHsNVZxZIjT774MqkijHv+sXpRz8vYEm67u TxnZEdYbknrtYalD5M+bj+2qCEg9KwuX8kOT5J5tSSEbqi5Zy6 rYE2nqWnQ7x5uv2JltqALyGmASlNeVGtQrSPi7XWp82sTFBTGf b8PpCYcNIHxNmjlPPPh1iiv3uujfYNBfwekqhaLLh+gKirRINQ E2AWiRGLNkbKd6uXQgLY9OVAfVq0Sh33YXg+xm1Z12RI4R7ZMC isJmN0ESGERScrbB69hUaxieL5VcrQF4sKqw51PH9 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik Subject: Re: svn commit: r238539 - head/sys/fs/smbfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2012 12:11:11 -0000 On 7/17/12 0:10 , Attilio Rao wrote: > 2012/7/16 Christian Brueffer : >> Author: brueffer >> Date: Mon Jul 16 22:07:29 2012 >> New Revision: 238539 >> URL: http://svn.freebsd.org/changeset/base/238539 >> >> Log: >> Simply error handling by moving the allocation of np down to where it is >> actually used. While here, improve style a little. > > Too bad that the biggest bug here is still in place. > Right now smbfs inserts in the mount list half-constructed vnodes. > Maybe you are interested in fixing this? > I can give it a shot, no promises though. Cheers, Chris