From owner-freebsd-bugs@FreeBSD.ORG Mon Jun 27 12:30:10 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 79DE41065670 for ; Mon, 27 Jun 2011 12:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3E76E8FC22 for ; Mon, 27 Jun 2011 12:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RCUAe1050115 for ; Mon, 27 Jun 2011 12:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RCUAlj050114; Mon, 27 Jun 2011 12:30:10 GMT (envelope-from gnats) Resent-Date: Mon, 27 Jun 2011 12:30:10 GMT Resent-Message-Id: <201106271230.p5RCUAlj050114@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Greg Becker Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B479B106564A for ; Mon, 27 Jun 2011 12:22:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id A515C8FC0A for ; Mon, 27 Jun 2011 12:22:47 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RCMlRi093304 for ; Mon, 27 Jun 2011 12:22:47 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p5RCMlx2093301; Mon, 27 Jun 2011 12:22:47 GMT (envelope-from nobody) Message-Id: <201106271222.p5RCMlx2093301@red.freebsd.org> Date: Mon, 27 Jun 2011 12:22:47 GMT From: Greg Becker To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/158339: replay_alloc() could dereference a null pointer... X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 12:30:10 -0000 >Number: 158339 >Category: kern >Synopsis: replay_alloc() could dereference a null pointer... >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jun 27 12:30:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Greg Becker >Release: 8.2 >Organization: CodeConcepts >Environment: FreeBSD dev4.i.cacheiq.com 8.2-STABLE FreeBSD 8.2-STABLE #5: Wed Jun 22 11:11:13 CDT 2011 gbecker@dev4.i.cacheiq.com:/usr/obj/usr/src/sys/DEV4 amd64 >Description: relay_alloc() (in src/sys/rpc/replay.c) calls malloc() with the M_NOWAIT flag, then proceeds to assume the pointer returned by malloc() is not NULL. This could cause a panic in a situation in which malloc() cannot satisfy the request. >How-To-Repeat: >Fix: Check the return code from malloc(). See attached patch. Patch attached with submission follows: --- /usr/src/sys/rpc/replay.c 2011-06-27 06:47:01.000000000 -0500 +++ /home/gbecker/replay.c 2011-06-27 06:46:21.000000000 -0500 @@ -115,14 +115,12 @@ rc->rc_count++; rce = malloc(sizeof(*rce), M_RPC, M_NOWAIT|M_ZERO); - if (rce) { - rce->rce_hash = h; - rce->rce_msg = *msg; - bcopy(addr, &rce->rce_addr, addr->sa_len); + rce->rce_hash = h; + rce->rce_msg = *msg; + bcopy(addr, &rce->rce_addr, addr->sa_len); - TAILQ_INSERT_HEAD(&rc->rc_cache[h], rce, rce_link); - TAILQ_INSERT_HEAD(&rc->rc_all, rce, rce_alllink); - } + TAILQ_INSERT_HEAD(&rc->rc_cache[h], rce, rce_link); + TAILQ_INSERT_HEAD(&rc->rc_all, rce, rce_alllink); return (rce); } >Release-Note: >Audit-Trail: >Unformatted: