From owner-freebsd-current@FreeBSD.ORG Sat Dec 3 21:05:45 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F1BC16A41F for ; Sat, 3 Dec 2005 21:05:45 +0000 (GMT) (envelope-from jasone@canonware.com) Received: from lh.synack.net (lh.synack.net [204.152.188.37]) by mx1.FreeBSD.org (Postfix) with ESMTP id 093DD43D66 for ; Sat, 3 Dec 2005 21:05:44 +0000 (GMT) (envelope-from jasone@canonware.com) Received: by lh.synack.net (Postfix, from userid 100) id B81305E48C5; Sat, 3 Dec 2005 13:05:44 -0800 (PST) Received: from [192.168.168.203] (moscow-cuda-gen2-68-64-60-20.losaca.adelphia.net [68.64.60.20]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lh.synack.net (Postfix) with ESMTP id ED34D5E4885; Sat, 3 Dec 2005 13:05:41 -0800 (PST) In-Reply-To: References: <0B746373-8C29-4ADF-9218-311AE08F3834@canonware.com> Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <7318D807-9086-4817-A40B-50D6960880FB@canonware.com> Content-Transfer-Encoding: 7bit From: Jason Evans Date: Sat, 3 Dec 2005 13:04:38 -0800 To: Claus Guttesen X-Mailer: Apple Mail (2.746.2) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on lh.synack.net X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: current@freebsd.org Subject: Re: New libc malloc patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Dec 2005 21:05:45 -0000 On Dec 3, 2005, at 12:45 PM, Claus Guttesen wrote: >> There's a new version of the patch available at: >> http://www.canonware.com/~jasone/jemalloc/jemalloc_20051202b.diff > > When I do a make buildworld I get: > > cc -fpic -DPIC -O2 -fno-strict-aliasing -pipe -march=athlon64 > -I/usr/src/lib/libc/include -I/usr/src/lib/libc/../../include > -I/usr/src/lib/libc/amd64 -D__DBINTERFACE_PRIVATE > -I/usr/src/lib/libc/../../contrib/gdtoa -DINET6 > -I/usr/obj/usr/src/lib/libc -DPOSIX_MISTAKE -I/usr/src/lib/libc/locale > -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP > -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c > /usr/src/lib/libc/stdlib/malloc.c -o malloc.So > cc -O2 -fno-strict-aliasing -pipe -march=athlon64 > -I/usr/src/lib/libc/include -I/usr/src/lib/libc/../../include > -I/usr/src/lib/libc/amd64 -D__DBINTERFACE_PRIVATE > -I/usr/src/lib/libc/../../contrib/gdtoa -DINET6 > -I/usr/obj/usr/src/lib/libc -DPOSIX_MISTAKE -I/usr/src/lib/libc/locale > -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP > -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c > /usr/src/lib/libc/stdlib/merge.c > /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_lock': > /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to > integer of different size > /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to > integer of different size > /usr/src/lib/libc/stdlib/malloc.c:853: warning: cast from pointer to > integer of different size > /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_unlock': > /usr/src/lib/libc/stdlib/malloc.c:894: warning: cast from pointer to > integer of different size > *** Error code 1 > /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_lock': > /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to > integer of different size > /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to > integer of different size > /usr/src/lib/libc/stdlib/malloc.c:853: warning: cast from pointer to > integer of different size > /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_unlock': > /usr/src/lib/libc/stdlib/malloc.c:894: warning: cast from pointer to > integer of different size > *** Error code 1 > 2 errors > *** Error code 2 > 1 error > *** Error code 2 > 1 error > *** Error code 2 > 1 error > *** Error code 2 > 1 error > *** Error code 2 > 1 error > make -j 3 buildworld 763,54s user 150,98s system 173% cpu 8:48,62 > total > > twin/usr/src#>uname -a > FreeBSD twin.gnome.no 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Thu Dec 1 > 21:38:11 CET 2005 root@twin.gnome.no:/usr/obj/usr/src/sys/TWIN > amd64 Did you use the 20051202b patch? I thought I had fixed the problem, but I don't have an amd64 system to test on. In any case, I'll be uploading up a new patch in a few minutes that removes the offending code entirely. Thanks, Jason