From owner-dev-commits-src-main@freebsd.org Fri May 7 17:47:07 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D804A636F72; Fri, 7 May 2021 17:47:07 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcHvb5fVbz4tcB; Fri, 7 May 2021 17:47:07 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from localhost (p200300d5d70db088d961eb679867db66.dip0.t-ipconnect.de [IPv6:2003:d5:d70d:b088:d961:eb67:9867:db66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 47B3A7C07; Fri, 7 May 2021 17:47:07 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Fri, 7 May 2021 19:47:06 +0200 From: Gordon Bergling To: Li-Wen Hsu Cc: Randall Stewart , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. Message-ID: References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 12.2-STABLE amd64 X-Host-Uptime: 7:42PM up 6:55, 4 users, load averages: 0.30, 0.36, 0.41 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 17:47:07 -0000 On Fri, May 07, 2021 at 05:39:37PM +0800, Li-Wen Hsu wrote: > On Thu, May 6, 2021 at 11:26 PM Randall Stewart wrote: > > > > The branch main has been updated by rrs: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=5d8fd932e418f03e98b3469c4088a36f0ef34ffe > > > > commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > > Author: Randall Stewart > > AuthorDate: 2021-05-06 15:22:26 +0000 > > Commit: Randall Stewart > > CommitDate: 2021-05-06 15:22:26 +0000 > > > > This brings into sync FreeBSD with the netflix versions of rack and bbr. > > This fixes several breakages (panics) since the tcp_lro code was > > committed that have been reported. Quite a few new features are > > now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the > > largest). There is also support for ack-war prevention. Documents > > comming soon on rack.. > > > > Sponsored by: Netflix > > Reviewed by: rscheff, mtuexen > > Differential Revision: https://reviews.freebsd.org/D30036 > > This seems braking LINT kernel build of powerpc: > > https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console > > Searching "error:" leads to: > > 00:08:15.153 /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: > error: implicit declaration of function 'tcp_hw_highest_rate' is > invalid in C99 [-Werror,-Wimplicit-function-declaration] > 00:08:15.153 high_rate = > tcp_hw_highest_rate(rack->r_ctl.crte); > 00:08:15.153 ^ > > and > > 00:08:15.163 /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > invalid in C99 [-Werror,-Wimplicit-function-declaration] > 00:08:15.163 high_rate = > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > rack->rc_inp); > 00:08:15.163 ^ > > I suspect this is because RATELIMIT is not defined in default powerpc > build? Is it safe to enable it? > > Best, > Li-Wen That should not be something RATELIMT related. I regular test 14-CURRENT on a RPi4B and the build today fails with -------------------------------------------------------------- >>> stage 3.1: building everything -------------------------------------------------------------- /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in C99 [-Werror,-Wimplicit-function-declaration] high_rate = tcp_hw_highest_rate(rack->r_ctl.crte); ^ /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is invalid in C99 [-Werror,-Wimplicit-function-declaration] high_rate = tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, rack->rc_inp); ^ /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:14166:15: error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in C99 [-Werror,-Wimplicit-function-declaration] high_rate = tcp_hw_highest_rate(rack->r_ctl.crte); ^ /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:14193:15: error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is invalid in C99 [-Werror,-Wimplicit-function-declaration] high_rate = tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, rack->rc_inp); ^ 4 errors generated. --- rack.o --- *** [rack.o] Error code 1 RATELIMIT is included in my KERNCONF since I use tcp_bbr(4) for a while on the RPi4B now. --Gordon