From owner-svn-src-head@FreeBSD.ORG Sat Dec 15 14:18:09 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B0B252C8; Sat, 15 Dec 2012 14:18:09 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) by mx1.freebsd.org (Postfix) with ESMTP id 24EDA8FC18; Sat, 15 Dec 2012 14:18:08 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id qBFEHuHY098221; Sat, 15 Dec 2012 18:17:56 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id qBFEHtQi098220; Sat, 15 Dec 2012 18:17:55 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 15 Dec 2012 18:17:55 +0400 From: Gleb Smirnoff To: Alfred Perlstein Subject: Re: svn commit: r244112 - head/sys/kern Message-ID: <20121215141755.GC94420@FreeBSD.org> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <50C9271C.70803@mu.org> <20121213090215.GP97487@FreeBSD.org> <201212141149.07671.jhb@freebsd.org> <50CBC285.7060307@mu.org> <20121215161414.V1029@besplex.bde.org> <50CC6E8D.6040707@mu.org> <20121215130149.GB94420@FreeBSD.org> <50CC7B26.5000708@mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <50CC7B26.5000708@mu.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Adrian Chadd , src-committers@FreeBSD.org, John Baldwin , svn-src-all@FreeBSD.org, Andriy Gapon , Navdeep Parhar , svn-src-head@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 14:18:09 -0000 On Sat, Dec 15, 2012 at 05:29:10AM -0800, Alfred Perlstein wrote: A> On 12/15/12 5:01 AM, Gleb Smirnoff wrote: A> > On Sat, Dec 15, 2012 at 04:35:25AM -0800, Alfred Perlstein wrote: A> > A> People keep beating this drum "all invariants/panics are there for a A> > A> reason", no, some happen to be bugs, and when I'm shipping code to a A> > A> customer, I may need to skip one of these buggy assertions. A> > A> > Yes, if you know any buggy assertions, please remove them from FreeBSD tree. A> > A> > A> Some people have responded to this by saying "alfred show me the buggy A> > A> assertions" to which my response is two fold "firstly, you're calling me A> > A> a liar which I do not appreciate, second prove to me that all the 1000s A> > A> of asserts have zero bugs and are not overly zealous about calling panic." A> > A> > We are not going to prove that. If you claim that some assertion is buggy, A> > you prove that it is buggy and happily remove it from source tree. Noone A> > is going to spend time proving you that 1000s of assertions are not buggy. A> > A> > Home reading for you: A> > A> > http://en.wikipedia.org/wiki/Russell%27s_teapot A> > A> Here is some reading for you: A> A> ------------------------------------------------------------------------ A> r244044 | adrian | 2012-12-08 17:08:44 -0800 (Sat, 08 Dec 2012) | 10 lines A> A> Don't panic if the stageq here is empty; just fall through with NULL A> pointers and leave the stage queue flush routine to just do nothing A> (since both head and tail here will be NULL.) A> A> This should quieten the "stageq empty" panic where the stageq itself A> is empty, but it won't fix the second KASSERT() here "staging queue empty" A> as that's likely a different underlying problem. A> A> PR: kern/174283 Yes, and important thing is that no one argued against this change, because Adrian explained that this particular assertion was incorrect and removed it. If you know any more incorrect assertions, please remove them as well, and no one will argue about that. But do not switch off all assertions in kernel. -- Totus tuus, Glebius.