From nobody Thu Jun 30 09:42:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7EAA7876B18; Thu, 30 Jun 2022 09:42:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LYYJX29F9z3vWS; Thu, 30 Jun 2022 09:42:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656582124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xy1DwLy96rtMtjxQSPaPSF5Jnw4XA2lYmKbjzFH9CV0=; b=iNhKMopt7oWDqIJS8SiUpKFufzkkGhBVb1X7sLlcTn3VrGSl4xvZvas6UdJp1tbetg1fLj Fm99OUoxrpRqelCmZA63w0cBhlCFIy92Et+4puKgKX96JSFkKxwYkNwvXsco7pBiJ5Zxuj u02rBNSzhFLuzrlmENel8v3tIzjrlEFsQa14uLK8uX0Z7JXJx50gxY3vIbHy8NPMBJVkvp ML1GWBkTLFZ+YDN8hjSTqBPHd2k2JilIACK+CqmJwcvDlRXbywBTTOp5Ar2AkkIMc/D7ws rcUoevcEuus9P4jIpMjvbiWPXHNp1DWrUt9fyC4sVGPbyUXaGZ9wV6clx/AIgQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 279BE23CC4; Thu, 30 Jun 2022 09:42:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25U9g4Uw086478; Thu, 30 Jun 2022 09:42:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25U9g4gk086477; Thu, 30 Jun 2022 09:42:04 GMT (envelope-from git) Date: Thu, 30 Jun 2022 09:42:04 GMT Message-Id: <202206300942.25U9g4gk086477@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: e81b8c36e757 - stable/12 - uhid(4): Don't read-ahead from the USB IN endpoint. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: e81b8c36e7578b5986c4837868eaee00711d6293 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656582124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xy1DwLy96rtMtjxQSPaPSF5Jnw4XA2lYmKbjzFH9CV0=; b=DTWDrjBT81DdqPnXVqvZ7eMq3W6fHl/VfRZy/GmJGK2D5sg+IVNuisgrLxp8OT7cJxgFAC fEdLsWiUPvtS0b9jv1xWU1/GU5l8NQQ75JEumM8VRLR8tSpDHmi+DwMxLEwst//pSt8gcS sK3Pfn6A316Ae3mG06jmZLIwwp5PgNu+sf96RoiaTlxIXeIZPzDXelyggexI6uy/sJIY1U vzz7j12v58oDbVGFj3ME8dToFoI0WugEAcqXy1lU/A97F+uEM2FJbkU3bTwY166UP0JMnh Hm83wUrVF3+tbkaz1jWo+DJrhqKHV4oBnjSG697LcnAQEHCvXIZ0NgEkzB6qSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656582124; a=rsa-sha256; cv=none; b=TKL9ztkquPuztnTBpeex63p/mQ82a4v+Hue6oAjTDc9+kpted550YpQ4plJRqbhy5w+HDp VY/Cv52ydGSf1kuy7jEXzDzlVNf78oi/+Dl57W1fbuTHpvnQxgXxmV6kwKpT1gwNF+U37R YO6a3Gz91D1a1oPqpov1BtqYdfOfNZS6D3EV5NaIVljf9ayvyiWv3yGC03eie92CK2tsFd zX0rFrGAfwSG3ShJsEm+t7vOiL+AyrpEB7VnkOs1DEYuXCLKl9RxY0JvVVJ6vME8hRGJfA VRpiyeqOifnf5vWoVJg7BjfOQ2EzMwLvpHhv53W3er5QTfEw8UcekCTQb/m8hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=e81b8c36e7578b5986c4837868eaee00711d6293 commit e81b8c36e7578b5986c4837868eaee00711d6293 Author: Hans Petter Selasky AuthorDate: 2022-06-23 17:39:21 +0000 Commit: Hans Petter Selasky CommitDate: 2022-06-30 09:41:26 +0000 uhid(4): Don't read-ahead from the USB IN endpoint. This avoids an issue where IN endpoint data received from the device right before the file handle is closed, gets lost. PR: 263995 Sponsored by: NVIDIA Networking (cherry picked from commit b6f615255d8bcdf40604005b11998eee86872364) --- sys/dev/usb/input/uhid.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/usb/input/uhid.c b/sys/dev/usb/input/uhid.c index 2caaf8e02861..d295daf13a69 100644 --- a/sys/dev/usb/input/uhid.c +++ b/sys/dev/usb/input/uhid.c @@ -213,6 +213,12 @@ uhid_intr_read_callback(struct usb_xfer *xfer, usb_error_t error) actlen = sc->sc_isize; usb_fifo_put_data(sc->sc_fifo.fp[USB_FIFO_RX], pc, 0, actlen, 1); + + /* + * Do not do read-ahead, because this may lead + * to data loss! + */ + return; } else { /* ignore it */ DPRINTF("ignored transfer, %d bytes\n", actlen);