From owner-freebsd-current@FreeBSD.ORG Wed Jul 14 00:04:34 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37E3216A4CE for ; Wed, 14 Jul 2004 00:04:34 +0000 (GMT) Received: from smtp4.server.rpi.edu (smtp4.server.rpi.edu [128.113.2.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFAEC43D2F for ; Wed, 14 Jul 2004 00:04:33 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp4.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i6E04VH7013919; Tue, 13 Jul 2004 20:04:32 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20040713232214.GA9507@dhcp50.pn.xcllnt.net> References: <26075.1089753893@critter.freebsd.dk> <20040713232214.GA9507@dhcp50.pn.xcllnt.net> Date: Tue, 13 Jul 2004 20:04:30 -0400 To: Marcel Moolenaar From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: Barney Wolff cc: Poul-Henning Kamp cc: current@freebsd.org Subject: Re: CVSUP and 5.2.1 RELEASE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2004 00:04:34 -0000 At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote: >On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote: >> >> a) how about if we print a warning and exit if DESTDIR is >> not defined? Are there "important" uses of `make world' >> which do not use DESTDIR? > >My thoughts exactly. See attached patch. I imagine we could debate the best wording to use for the warning message, but I do think this patch would be an improvement for our users. If it saves a few users from a trashed system, it will be a valuable change. In my quick testing, it seemed to do the right things. One other thing we might want to change is the part where we: # Set a reasonable default .MAIN: all I am not so sure that is a reasonable default. Someone who roams into /usr/src and types a plain `make' should probably be told to read the documentation for what to do. However, this does not bother me much. I think `make world' is the bigger issue. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu