From owner-svn-src-head@freebsd.org  Tue Jun 19 05:27:01 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12B901020842
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Tue, 19 Jun 2018 05:27:01 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B8F6F6B17B
 for <svn-src-head@freebsd.org>; Tue, 19 Jun 2018 05:27:00 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: from mail-yw0-f174.google.com (mail-yw0-f174.google.com
 [209.85.161.174])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: eadler)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 7DF5719869
 for <svn-src-head@freebsd.org>; Tue, 19 Jun 2018 05:27:00 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: by mail-yw0-f174.google.com with SMTP id b125-v6so6473734ywe.1
 for <svn-src-head@freebsd.org>; Mon, 18 Jun 2018 22:27:00 -0700 (PDT)
X-Gm-Message-State: APt69E25026ihyhDkC8NmeW3+EPMhu+CT8hx8AiEfD6ChRwKBowDjOfk
 dxVAsX0IgjPbAXJYkOo0tgnPKpbtS6uxl4otBNlSqQ==
X-Google-Smtp-Source: ADUXVKJWd3EW80zhhUjv4tKxtG0Vn5pJOAltK7i+SnsLFldP1lOc4EN9CAhrxsIqOrRqabZKDv22Kn1V69aflTroGFk=
X-Received: by 2002:a81:b70b:: with SMTP id
 v11-v6mr7064879ywh.182.1529386019871; 
 Mon, 18 Jun 2018 22:26:59 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 22:26:29
 -0700 (PDT)
In-Reply-To: <77224f10-7633-1122-8099-466f2a35942f@FreeBSD.org>
References: <201806170514.w5H5Epts050842@repo.freebsd.org>
 <77224f10-7633-1122-8099-466f2a35942f@FreeBSD.org>
From: Eitan Adler <eadler@freebsd.org>
Date: Mon, 18 Jun 2018 22:26:29 -0700
X-Gmail-Original-Message-ID: <CAF6rxgnQgb4NNoamBxrraOTBTt-nds-zkb2tdPxWi1=wbouv=g@mail.gmail.com>
Message-ID: <CAF6rxgnQgb4NNoamBxrraOTBTt-nds-zkb2tdPxWi1=wbouv=g@mail.gmail.com>
Subject: Re: svn commit: r335278 - head/bin/pwd
To: John Baldwin <jhb@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 05:27:01 -0000

On 18 June 2018 at 10:57, John Baldwin <jhb@freebsd.org> wrote:
> On 6/16/18 10:14 PM, Eitan Adler wrote:
>> Author: eadler
>> Date: Sun Jun 17 05:14:50 2018
>> New Revision: 335278
>> URL: https://svnweb.freebsd.org/changeset/base/335278
>>
>> Log:
>>   pwd: mark usage as dead
>
> You keep committing changes like this and ignoring e-mails about them.

I replied both the first time and this time. I may have
(accidentally?) ignored similar emails though. The question I have is
other than the mild code churn what's the harm?

> What broken compiler are you using that doesn't properly inherit __dead2
> from the call to exit()?

In this case, scan-build50 was getting annoyed.





-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams