From owner-cvs-src@FreeBSD.ORG Thu Aug 12 00:33:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 272E416A4CE; Thu, 12 Aug 2004 00:33:59 +0000 (GMT) Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de [212.202.50.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id C5CCC43D45; Thu, 12 Aug 2004 00:33:58 +0000 (GMT) (envelope-from eikemeier@fillmore-labs.com) Received: from dhcp-8.local ([172.16.0.8] helo=dhcp-10.local) by fillmore.dyndns.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.41 (FreeBSD)) id 1Bv3XX-000Phj-FX; Thu, 12 Aug 2004 02:33:57 +0200 Date: Thu, 12 Aug 2004 02:35:33 +0200 Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v482) To: Doug Barton , re@FreeBSD.org From: Oliver Eikemeier In-Reply-To: <20040811171300.N54010@ync.qbhto.arg> Message-Id: <8576C147-EBF7-11D8-887A-00039312D914@fillmore-labs.com> Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: Ceri Davies cc: cvs-src@FreeBSD.org cc: Alfred Perlstein cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add Makefile add.h extract.c futil.c main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/create Makefile create.h main.c perform.c pkg_create.1 pl.c src/usr.sbin/pkg_install/delete Makefile delete.h main.c perform.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2004 00:33:59 -0000 Doug Barton wrote: > On Wed, 11 Aug 2004, Alfred Perlstein wrote: > >> * Ceri Davies [040811 09:24] wrote: >>> On Wed, Aug 11, 2004 at 04:16:24PM +0000, Oliver Eikemeier wrote: >>>> eik 2004-08-11 16:16:24 UTC >>>> >>>> >>>> - replace the perl version of pkg_version(1) by its C equivalent, >>>> which means that `pkg_version -c' does no longer work >>> >>> I don't think that this should have gone into RELENG_4, in this case. >> >> Agreed. We don't break things that used to work in 4.x unless there >> is dire need. > > Also agreed. This should not have happened, and I'd like to see it > backed out. Before I get a million replies to this commit: When anyone from re@ thinks it is worth the effort, I will add an -c option to the C pkg_version code ASAP. I believe backing this out won't be beneficial for -STABLE users, since they'll loose a lot of features (and speed). Has anyone on this thread *ever* used that option? -Oliver