From owner-freebsd-bugs  Fri Oct  6 21:40: 9 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 88AA937B66C
	for <freebsd-bugs@FreeBSD.org>; Fri,  6 Oct 2000 21:40:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id VAA72655;
	Fri, 6 Oct 2000 21:40:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from port294.megapop.eunet.no (port294.megapop.eunet.no [193.91.253.44])
	by hub.freebsd.org (Postfix) with ESMTP id E41F137B503
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Oct 2000 21:34:17 -0700 (PDT)
Received: (from suiram@localhost)
	by suiram.freebsd.org (8.9.3/8.9.3) id EAA23533;
	Sat, 7 Oct 2000 04:07:23 +0200 (CEST)
	(envelope-from suiram)
Message-Id: <200010070207.EAA23533@suiram.freebsd.org>
Date: Sat, 7 Oct 2000 04:07:23 +0200 (CEST)
From: mbendiks@eunet.no
Reply-To: mbendiks@eunet.no
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/21805: [patches] Fix erronous comment in msdosfs
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         21805
>Category:       kern
>Synopsis:       msdosfs_vnops comments are incorrect wrt locking
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 06 21:40:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Marius Bendiksen
>Release:        FreeBSD 4.1-RELEASE i386
>Organization:
n/a
>Environment:

	not relevant.

>Description:

	In /sys/msdosfs/msdosfs_vnops.c, function msdosfs_rename(), the
	comments erronously claim that the parent is locked. This isn't
	correct, according to the UFS code and documentation. Also, the
	code doesn't do it anyway, so someone probably just forgot it.

>How-To-Repeat:

	not relevant.

>Fix:

	diff -u4 in /sys/msdosfs, output follows:

--- msdosfs_vnops.c.orig	Sun Sep 24 14:20:20 2000
+++ msdosfs_vnops.c	Sun Sep 24 14:21:54 2000
@@ -865,11 +865,9 @@
 	return (error);
 }
 
 /*
- * DOS filesystems don't know what links are. But since we already called
- * msdosfs_lookup() with create and lockparent, the parent is locked so we
- * have to free it before we return the error.
+ * DOS filesystems don't know what links are.
  */
 static int
 msdosfs_link(ap)
 	struct vop_link_args /* {

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message