From owner-cvs-all Tue Jan 14 11:20:28 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4105837B407 for ; Tue, 14 Jan 2003 11:20:25 -0800 (PST) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EC1243F43 for ; Tue, 14 Jan 2003 11:20:23 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 22952 invoked from network); 14 Jan 2003 19:20:28 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 14 Jan 2003 19:20:28 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h0EJKLUT007158; Tue, 14 Jan 2003 14:20:21 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030114163519.GA48612@dragon.nuxi.com> Date: Tue, 14 Jan 2003 14:20:32 -0500 (EST) From: John Baldwin To: "David O'Brien" Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_seq.h tcp_timer. Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jeffrey Hsu Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14-Jan-2003 David O'Brien wrote: > On Mon, Jan 13, 2003 at 10:54:45AM -0800, Jeffrey Hsu wrote: >> > hsu 2003/01/13 03:01:20 PST >> > >> > Modified files: >> > sys/netinet tcp_input.c tcp_seq.h tcp_timer.c >> > tcp_var.h >> > Log: >> > Fix NewReno. >> > >> > Reviewed by: Tom Henderson >> > >> > Revision Changes Path >> > 1.187 +44 -41 src/sys/netinet/tcp_input.c >> > 1.19 +1 -1 src/sys/netinet/tcp_seq.h >> > 1.56 +2 -5 src/sys/netinet/tcp_timer.c >> > 1.84 +3 -1 src/sys/netinet/tcp_var.h >> >> The state for when we are enter, are in, and leave the NewReno Fast Recovery >> period has been split out from t_dupacks into its own state variable, snd_high, > ...snip... > > You should do a forced commit (cvs ci -f ..list.of.files..) and add this. Yes, please. Commit logs are meant to be informative. When browsing a long history of commits via cvs log, one doesn't want to have to do a diff each time to figure out what the log messages really mean. Just because a committer understands the commit they are making at the time doesn't mean that they will fully remember it later on and doesn't mean that other people who come along later will understand it either. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message