From nobody Tue Jan 30 17:56:58 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TPXtM0GBcz59GsN; Tue, 30 Jan 2024 17:56:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPXtL6gRfz4Ns0; Tue, 30 Jan 2024 17:56:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706637418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kmYsTLL2VvV/4yv/URzSeFb5E8EB6CK5+h6vX0UO0Kc=; b=dkXt3ycOjV7GQ5MHM8E3o/hftHVy1llN5gRC1KBvoeG044V7V3DM5w5OfremePE5SOGpbG 14QNpL8kjFYgWccu7MGL+8beblLKwnswYpHTIKRLw2WBxXTGdP9FmIn0hdDSviY0gSBMC8 elY7yOxOEmAH88qpt+Q+M7q+NVl2rNNo/iBFjX4X9VA6Qtcbi3HblgxpdATfv4w8kZ+uKP TKTOL3yrIncgUUF8tmBM0DhSszTqF8Lve2TnsukSQ3ZiPl1N/hQeYpff/MxXeeiu3uHzaZ R+7PKVo0P7jpLL7So15JhKOg0AbxA2Q4yfIKSRcyyNyif7amAbBo9em7AOMggg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706637418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kmYsTLL2VvV/4yv/URzSeFb5E8EB6CK5+h6vX0UO0Kc=; b=cBOIYOx6vkheAj7IEqueDVSjJ1olarWkBG2HW8lAWn4aTvgcbXbB6EvTUsw+SKE17gLc15 udUnuT/Sab+owGaonoTVltaHG3cLugHOnCTNaxwoUlqQq4ePe/zvVbeVVFjTeXushC1Kf1 96UmOR2d/zkv96Sq0Q9QSy8JUhDGmzuha/v5rvnj3dvk4jyWSKvUk/ThGCL9D4XY8nsiNa 6oE/6lrmJbBulv3IqgpaN73VSOKtrYNYaU6t35Vl3LzfXXmE02VCftiZ2iYnFYlTRw0woS ocxnmIP1FSWQqibug6q6TaSTYvYfk28VumILQINc8rBvF9PIHd/RucA7uHCyGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706637418; a=rsa-sha256; cv=none; b=jV2FG1WRV1L3BE3vHbkHtR6Yy6Y764o/6bS1JYLad4fyuVAgOfb2duLd1ovdO1Q8lz2WUK UdBlKu1Amcan6E2XiY54RGxWOmVc2bos9Hu73oOsJtcG+NGpG81zeBgLH4h/DRRJ4ru3Za luSs//B90A6wmZqDiCEriiI8PTTRIrgmM2McD8kghLHqB7OY8dHl+c+ITjjCFWtv3Qv/uC WICouKd6T6oAdaa6KiarIr/yb36y2sXH7Qvz6m0cUmapzbejQUklWv91H1bzLvzaMYs6bc emex5O0k1j7Hwl3Ul/M0B/rtEUBiGaDrjBZRaqCOLZqejrJFNF3DmhpL1f5GJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TPXtL5ch1zldb; Tue, 30 Jan 2024 17:56:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40UHuwMr067292; Tue, 30 Jan 2024 17:56:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40UHuw2d067289; Tue, 30 Jan 2024 17:56:58 GMT (envelope-from git) Date: Tue, 30 Jan 2024 17:56:58 GMT Message-Id: <202401301756.40UHuw2d067289@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: ca89a51d407a - stable/12 - msun: remove fabs from Symbol.map, and adjust comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: ca89a51d407a1d6b78d27b8d407f0c12f7c8c9a1 Auto-Submitted: auto-generated The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=ca89a51d407a1d6b78d27b8d407f0c12f7c8c9a1 commit ca89a51d407a1d6b78d27b8d407f0c12f7c8c9a1 Author: Dimitry Andric AuthorDate: 2024-01-27 21:24:38 +0000 Commit: Dimitry Andric CommitDate: 2024-01-30 17:52:55 +0000 msun: remove fabs from Symbol.map, and adjust comment We have s_fabs.c, but fabs(3) is already provided by libc due to historical reasons, so it is not compiled into libm. When the linker does not use --undefined-version, this leads to a complaint about the symbol being nonexistent, so remove it from Symbol.map. While here, adjust the comment about some functions being supplied by libc: while it is true that all these are indeed in libc, libm still includes its own versions of frexp(3), isnan(3), isnanf(3), and isnanl(3). Reported by: Steve Kargl MFC after: 3 days (cherry picked from commit d04e03c19a8d7660ea36f62720eef9bc96b69889) --- lib/msun/Makefile | 3 ++- lib/msun/Symbol.map | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/Makefile b/lib/msun/Makefile index 4771de91c561..15c56d10a8e3 100644 --- a/lib/msun/Makefile +++ b/lib/msun/Makefile @@ -143,7 +143,8 @@ COMMON_SRCS+= catrig.c catrigf.c \ s_cproj.c s_cprojf.c s_creal.c s_crealf.c s_creall.c \ s_csinh.c s_csinhf.c s_ctanh.c s_ctanhf.c -# FreeBSD's C library supplies these functions: +# FreeBSD's C library supplies these functions (but note we still have s_frexp.c +# and s_isnan.c enabled above, so they are duplicated): #COMMON_SRCS+= s_fabs.c s_frexp.c s_isnan.c s_ldexp.c s_modf.c # Exclude the generic versions of what we provide in the MD area. diff --git a/lib/msun/Symbol.map b/lib/msun/Symbol.map index 51deded732f0..435fbed5642e 100644 --- a/lib/msun/Symbol.map +++ b/lib/msun/Symbol.map @@ -89,7 +89,6 @@ FBSD_1.0 { exp2f; expm1; expm1f; - fabs; fabsf; fabsl; fdim;