Date: Wed, 14 Sep 2016 16:03:37 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: "Bruce Evans" <bde@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include Message-ID: <439B0258-5FEB-4136-BF30-72A0B6E0AEDD@lists.zabbadoz.net> In-Reply-To: <201609141257.u8ECveAs020350@repo.freebsd.org> References: <201609141257.u8ECveAs020350@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 Sep 2016, at 12:57, Bruce Evans wrote: > Author: bde > Date: Wed Sep 14 12:57:40 2016 > New Revision: 305807 > URL: https://svnweb.freebsd.org/changeset/base/305807 > > Log: > > Modified: > head/sys/amd64/amd64/trap.c breaks all amd64 LINT* kernels: /scratch/tmp/bz/head.svn/sys/amd64/amd64/trap.c:937:22: error: use of undeclared identifier 'frame'; did you mean 'free'? if (!TRAPF_USERMODE(frame)) { ^~~~~ free ./machine/cpu.h:53:9: note: expanded from macro 'TRAPF_USERMODE' (ISPL((framep)->tf_cs) == SEL_UPL) ^ ./x86/segments.h:48:20: note: expanded from macro 'ISPL' #define ISPL(s) ((s)&3) /* priority level of a selector */ ^ /scratch/tmp/bz/head.svn/sys/sys/malloc.h:175:6: note: 'free' declared here void free(void *addr, struct malloc_type *type); ^ /scratch/tmp/bz/head.svn/sys/amd64/amd64/trap.c:937:7: error: member reference base type 'void (void *, struct malloc_type *)' is not a structure or union if (!TRAPF_USERMODE(frame)) { ^~~~~~~~~~~~~~~~~~~~~ ./machine/cpu.h:53:16: note: expanded from macro 'TRAPF_USERMODE' (ISPL((framep)->tf_cs) == SEL_UPL) ~~~~~~~~~~~~~^~~~~~~~ ./x86/segments.h:48:20: note: expanded from macro 'ISPL' #define ISPL(s) ((s)&3) /* priority level of a selector */ ^ 2 errors generated. --- trap.o --- *** [trap.o] Error code 1 bmake[5]: stopped in /storage/head/obj/scratch/tmp/bz/head.svn/sys/LINT From owner-svn-src-all@freebsd.org Wed Sep 14 16:08:25 2016 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A4ADBDAE69; Wed, 14 Sep 2016 16:08:25 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EEE691B6C; Wed, 14 Sep 2016 16:08:24 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u8EG8OX7001241; Wed, 14 Sep 2016 16:08:24 GMT (envelope-from bz@FreeBSD.org) Received: (from bz@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u8EG8O9H001240; Wed, 14 Sep 2016 16:08:24 GMT (envelope-from bz@FreeBSD.org) Message-Id: <201609141608.u8EG8O9H001240@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bz set sender to bz@FreeBSD.org using -f From: "Bjoern A. Zeeb" <bz@FreeBSD.org> Date: Wed, 14 Sep 2016 16:08:24 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r305811 - head/sys/amd64/amd64 X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 14 Sep 2016 16:08:25 -0000 Author: bz Date: Wed Sep 14 16:08:23 2016 New Revision: 305811 URL: https://svnweb.freebsd.org/changeset/base/305811 Log: Try to fix LINT builds after r305807. Seems to be a simple s&r error I missed while reading through the 1st time as well. Modified: head/sys/amd64/amd64/trap.c Modified: head/sys/amd64/amd64/trap.c ============================================================================== --- head/sys/amd64/amd64/trap.c Wed Sep 14 14:48:00 2016 (r305810) +++ head/sys/amd64/amd64/trap.c Wed Sep 14 16:08:23 2016 (r305811) @@ -934,7 +934,7 @@ amd64_syscall(struct thread *td, int tra ksiginfo_t ksi; #ifdef DIAGNOSTIC - if (!TRAPF_USERMODE(frame)) { + if (!TRAPF_USERMODE(td->td_frame)) { panic("syscall"); /* NOT REACHED */ }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?439B0258-5FEB-4136-BF30-72A0B6E0AEDD>