From owner-svn-ports-head@freebsd.org Sun Jul 28 02:18:29 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6EDC2C7131; Sun, 28 Jul 2019 02:18:29 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 52291804D2; Sun, 28 Jul 2019 02:18:29 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 3D0881D193; Sun, 28 Jul 2019 02:18:29 +0000 (UTC) From: Jan Beich To: Oliver Lehmann Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r507479 - in head/graphics/ogre3d: . files References: <201907272356.x6RNu2f6008115@repo.freebsd.org> Date: Sun, 28 Jul 2019 04:18:26 +0200 In-Reply-To: <201907272356.x6RNu2f6008115@repo.freebsd.org> (Oliver Lehmann's message of "Sat, 27 Jul 2019 23:56:02 +0000 (UTC)") Message-ID: <36iq-j40d-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 52291804D2 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2019 02:18:29 -0000 Oliver Lehmann writes: > +BUILD_DEPENDS= pkgconf:devel/pkgconf Already set by USES=pkgconfig. > +USE_SDL= sdl sdl2 sdl12 and sdl20 have conflicting symbols, so both cannot be loaded in the same runtime. According to "poudriere testport" shared library check only the latter appears to be used. > +CMAKE_ARGS+= -DOGRE_BUILD_RENDERSYSTEM_GL3PLUS:BOOL=OFF \ > + -DOGRE_BUILD_RENDERSYSTEM_GL:BOOL=OFF \ > + -DOGRE_BUILD_RENDERSYSTEM_GLES2:BOOL=OFF \ > + -DOGRE_BUILD_COMPONENT_PYTHON:BOOL=OFF \ > + -DOGRE_BUILD_COMPONENT_JAVA:BOOL=OFF \ > + -DOGRE_BUILD_COMPONENT_CSHARP:BOOL=OFF \ > + -DOGRE_BUILD_PLUGIN_FREEIMAGE:BOOL=OFF \ > + -DOGRE_BUILD_PLUGIN_EXRCODEC:BOOL=OFF \ > + -DOGRE_CONFIG_ENABLE_ZIP:BOOL=ON \ > + -DOGRE_INSTALL_DOCS:BOOL=OFF \ > + -DOGRE_INSTALL_SAMPLES_SOURCE:BOOL=OFF Why not convert these to CMAKE_OFF as well? > +DOCS_BUILD_DEPENDS= doxygen:devel/doxygen > +DOCS_CMAKE_BOOL= OGRE_INSTALL_DOCS Maybe rename DOCS to DOXYGEN to allow users skip the dependency globally via OPTIONS_UNSET+=DOXYGEN in /etc/make.conf. > +OPENEXR_DESC= Build EXR Codec plugin Probably redundant. See Mk/bsd.options.desc.mk > +OPENGL_DESC= OpenGL support Probably redundant. See Mk/bsd.options.desc.mk > +OPENGL_LIB_DEPENDS= libGL.so:graphics/mesa-libs Convert to USES=gl + USE_GL=gl. > +OPENGL_VARS= USE_XORG+=sm ice Why not OPENGL_USE=sm ice? _VARS usage here is improperly escaped, turning "ice" into a separate variable. > +PROFILE_DESC= Enable internal profiling support Probably redundant. See Mk/bsd.options.desc.mk > +CSHARP_DESC= Build Csharp bindings > +CSHARP_CMAKE_BOOL= OGRE_BUILD_COMPONENT_CSHARP > +CSHARP_BUILD_DEPENDS= swig3.0:devel/swig30 Maybe rename CSHARP to MONO for consistency with other ports. > +JAVA_DESC= Build java bindings Probably redundant. See Mk/bsd.options.desc.mk > +JAVA_CMAKE_BOOL= OGRE_BUILD_COMPONENT_JAVA > +JAVA_BUILD_DEPENDS= swig3.0:devel/swig30 > +JAVA_VARS= USE_JAVA=yes \ Why not JAVA_USE=JAVA=yes ? > + CMAKE_ARGS+=-DJAVA_HOME=${JAVA_HOME} Why not JAVA_CMAKE_ON=-DJAVA_HOME=${JAVA_HOME} ? As JAVA_HOME is exported via environ(7) and cmake-modules(7) picks it up the line maybe redundant. > +PYTHON_DESC= Build python bindings Probably redundant. See Mk/bsd.options.desc.mk > +CXXFLAGS+= -DNDEBUG -I${LOCALBASE}/include - Maybe disable -DNDEBUG when debugging e.g., ${WITH_DEBUG:D:U-DNDEBUG} - Maybe replace -I${LOCALBASE}/include with USES=localbase:ldflags > +# BROKEN_aarch64= does not compile: error: class member cannot be redeclared Builds fine, see https://reviews.freebsd.org/P280