From owner-cvs-src@FreeBSD.ORG Sat Nov 19 19:53:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E918416A41F; Sat, 19 Nov 2005 19:53:36 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E6AA43D53; Sat, 19 Nov 2005 19:53:36 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (ppp-71-139-0-107.dsl.snfc21.pacbell.net [71.139.0.107]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id jAJJrcDe018129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 Nov 2005 11:53:39 -0800 Message-ID: <437F82A1.6080504@root.org> Date: Sat, 19 Nov 2005 11:53:05 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Damien Bergamini References: <20051119165547.0A4BD16A43D@hub.freebsd.org> In-Reply-To: <20051119165547.0A4BD16A43D@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/iwi Makefile src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2005 19:53:37 -0000 Damien Bergamini wrote: > damien 2005-11-19 16:54:55 UTC > > FreeBSD src repository > > Modified files: > sys/modules/iwi Makefile > sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h > Log: > Load firmware images directly from the filesystem (looks into /etc/firmware > directory by default) without requiring the user to load them by hand using > e.g iwicontrol. Get rid of the old ioctl crud. > Updated iwi-firmware port coming soon. > > Obtained from: OpenBSD > > Revision Changes Path > 1.24 +157 -136 src/sys/dev/iwi/if_iwi.c > 1.8 +6 -0 src/sys/dev/iwi/if_iwireg.h > 1.8 +2 -17 src/sys/dev/iwi/if_iwivar.h > 1.3 +1 -1 src/sys/modules/iwi/Makefile I'm a little concerned about this change. The notes claim the firmware is loaded after a resume from the filesystem as well as at initialization time. So your driver is then assuming the ATA driver is fully reinitialized before your driver's resume method can be called. You can't assume that since it's not a child device of ATA. Also, I'm concerned about the unnecessary use of caddr_t (which I don't think will work on PAE or 64 bit systems). -- Nate